-
Notifications
You must be signed in to change notification settings - Fork 430
Publish tidy-html5 to a Debian repo #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mcandre as some background I would add - Both I and @balthisar have added to an old bug report - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655200#70 Maybe a current Debian user could file a new bug? Add their voice to ours... For Ubuntu I am holding open a question - https://answers.launchpad.net/ubuntu/+source/tidy/+question/276623 - Maybe other Ubuntu users could add to this, or add something new? As first I thought it may be the holiday season that delayed things, but we are now nearly at the end of January 2016 and still no results!!! It is really ugly that the tidy offered is a 2009 cvs source release... or have I missed something here? What else can we do? |
Hi Manfred, Re: Update HTML Tidy package Thank you for help searching around for a solution to this... you In fact your search link leads to an email from Jason, clearly So am also sending this to the MIA team - Dear MIA Team, Hi, I hope you can help HTML Tidy. Back in 2011-06-01 Jason advised he no longer has time to maintain I do not know your process in choosing a new maintainer, but note Hope you can help get HTML Tidy updated, when you get a chance. Last release: https://github.com/htacg/tidy-html5/releases/tag/5.1.25 Regards, On Mon, Jan 25, 2016 at 4:12 PM, Manfred Hampl <
|
On Mon, Jan 25, 2016 at 05:38:37PM +0100, Geoff McLane wrote:
The MIA team doesn't "choose" a new maintainer, the most it can do is Whoever wants to adopt (and maintain) it, I think he should feel free regards, GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .'' |
Hi Mattia, hi Jason,
I'm willing to adopt the tidy package, and would suggest it for https://wiki.debian.org/Teams/CollabMaint Cheers! Daniel |
I am holding my question open... Daniel has offered to adopt tidy package maintenance, but things seem to be moving very slowly... if at all.. Anything anybody can do to move this along would be much appreciated... Specifically, could any Debian or Ubuntu developers, who are familiar with Tidy, please HELP! |
Just posted this on my question to keep it open...
Can anybody HELP with this? |
Since we are considering a release 5.2 shortly, changing the milestone on this to indefinite! |
Cross posted on question... As can be seen here - htacg/html-tidy.org.binaries#1 - I Maybe you could help with this? Then when/if you take over orphaned Tidy Or maybe you or others could point me to some good tutorials on building Geoff. |
@mcandre - Wow, this feels like a break-through! Check out https://github.com/danielhjames/tidy-packaging Can others help Daniel, me, and Tidy with this? Thanks... I am still learning Debian packaging, but understand a test can be done with -
All help very much appreciated... |
pbuilder-dist takes quite a lot of setup and you may not need it. It is only necessary to use pbuilder-dist for a clean chroot build, like when making packages for distribution. All you really need for a local test is the orig.tar.gz and the debian directory from the above git repo. You can omit the -S option on dpkg-buildpackage (which means create a source package only) and you will get installable .deb packages built for the host distro. |
See #406 for a DEB build problem... Maybe you can help... |
tidy-html5 is now in the New queue for acceptance into Debian: https://ftp-master.debian.org/new.html |
As @danielhjames points out, some massive steps forward ;=)) http://anonscm.debian.org/cgit/collab-maint/tidy.git/ Thank you! Read all about it - On 08/06/16 15:28, Ludovic Rousseau wrote:
AND On 08/06/16 15:37, Ludovic Rousseau wrote:
AND On 08/06/16 16:29, Daniel James wrote:
AND On 08/06/16 17:29, Ludovic Rousseau wrote:
; eof - ref: tidy-199-debian-build.txt |
tidy-html5 is now in the New queue for acceptance into Debian:
https://ftp-master.debian.org/new.html
Why not update current tidy? Why have new package?
Also, your binary package already exists in Sid, which means this
cannot be accepted. If you wish to use libtidy-dev, then that has to be
via current tidy package, not new one.
|
Hi Adam, this is an update of the current tidy package. The reason that the source package name changed is because it changed upstream, so it has to go into Debian's New queue. Also, the name of the libtidy package changed because the shared object filename now has a 5.x suffix, currently /usr/lib/libtidy.so.5.2.0. In the libtidy5 debian/control file we have... Replaces: libtidy-0.99-0, libtidy0 |
On Thu, 09 Jun 2016 03:06:48 -0700
It still would end up in New because you have different soname, so new I don't see request to remove old tidy. New upstream is fine, but package is continuing. This is not a rewrite. Also, tidy needs compatibility headers since they were renamed. So
That is wrong. Your libtidy5 should not be replacing libtidy0. It should co-exist. Also, that README.source is from old CVS? Shouldn't exist there (even PS. I didn't look at the Debian package, just looking at what is |
Hi Adam, thanks for the offer of help, do you use collab-maint? I removed README.source as you are right, it is from the old package. Please see the last commit on http://anonscm.debian.org/cgit/collab-maint/tidy.git/ libtidy-0.99-0 had a Conflicts: on libtidy0 and I don't think libytidy0 has been in Debian since the year 2005 (according to the changelog) so I guess there is not much chance of libtidy5 and libtidy0 co-existing. Supposing we had libtidy5 co-existing with the also very old libtidy-0.99-0 (from the year 2009), wouldn't that mean having two versions of the same library, but only one supported upstream? Also, I recall the libtidy-dev package provides a symlink for the library, wouldn't that conflict? Cheers! Daniel |
Yes, I do have access to collab-maint, but not from here. I can look at FYI, currently tidy is in process of getting updated at SUSE. It's just
No, devel provides symlink to the package it depends on, so something libtidy.so -> libtidy.so.5 hence no problems having libtidy-0.99-0 and libtidy5 installed at same Sometimes users have very old software that they can't |
@AdamMajer, @danielhjames, thanks for your comments... it is very good to read... we are certainly interested in
As a tidy maintainer, absolutely agree.
Adding this link is exactly the upgrade of tidy that is required, requested, here - across every distribution... I have not asked my friends, the original SF maintainers, exactly why that last release 2009, was named: 0.99, but when the baton was passed on, to us, HTACG, we chose the first release name to be Tidy 5.0.0... but no API change! ... lots and lots of history in that... Now, in building the Debian package, somewhere along the line I might have thought changing the base name would be ok for a Debian release... but fully agree, if it is possible, install and do the above link update... all is done... Also agreed... no delete of the last... if an app has the direct link to The sample console app, Then any current app, linked to the generic So where does this go next? Do we, as Tidy, wait for the new Debian name approval? I am sort of ok with that, if this gets tidy into distribution, after a much too long delay... 6-7 plus years... Or, are there some simple debian build steps which will keep the preferred single name of tidy... ie no new approval is required... Any help, ideas, you can provide would be much appreciated... thanks for the comments, and to @danielhjames for big efforts to get this moving... on a very important issue to us... getting the tidy update into distribution... |
On Sat, 11 Jun 2016 17:07:07 -0700 Geoff McLane
Good, because OpenSUSE has tidy5 as new tidy. Uploaded it last week. So https://build.opensuse.org/package/show/openSUSE:Factory/tidy The only thing is, that you do have an ABI change hence you would have http://stackoverflow.com/questions/3784389/difference-between-api-and-abi For example, when you added new enums, that is ABI change since you've ABI change require soname to be changed because software has to be Anyway, this is probably old news to you.
It just means user can install libtidy-0.99-0.so from archive When base tidy is updated, then this automatically triggers rebuilt
That is fine. The binary can change to have new features and all that.
Have you contacted current Debian tidy maintainer?
|
Hi @AdamMajer, hi @geoffmcl, the official Debian tidy maintainer has not been active with this package for some years, which is why I offered to help prepare this new set of packages. The symlink: This symlink points to the actual installed library, which is libtidy.so.5.2.0 for this particular release. The next step is that when the new package gets checked in Debian's NEW queue, it will either be accepted, or we will fix it up until it is accepted. This can take a while, but new uploads should be quicker after that. Cheers! Daniel |
Well, I've just contacted the Debian maintainer and he said he'll like to keep maintaining tidy and has updated the package to tidy5. He just can't upload it because his GPG key was removed (long story, but Debian had lots of GPG keys removed in the 1k to 2+k RSA keylength transition). I've told him I can upload his package on the weekend. And then Debian will have tidy5 too 👍 |
Hi Adam, that's a good result, thanks. Will collab-maint be used in future? |
Hi @AdamMajer, I have not tried to contact the tidy maintainer Jason Thomas. His latest tidy upload was in Dec 2009. I guess his PGP key has been removed long after that date. tidy looked abandoned. I am sorry if I made a mistake. I am not sure it is a good idea to upload now a new version of tidy5. I would wait until the NEW package is handled. |
On Tue, 14 Jun 2016 04:54:36 -0700
Tidy didn't have upstream for a while too. There was little to upload. But just to re-iterate,
Always a good idea to email the current maintainer. It probably would |
Hi @AdamMajer, we have been aware of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655200 since at least 2013. I emailed Jason via this bug report in March 2015 offering help, and he was emailed again by Geoff in January 2016, with no response. As a volunteer, I do appreciate that time is not always available to respond, so that's not a criticism. Your assistance with compat headers would be very welcome, please take a look at http://anonscm.debian.org/cgit/collab-maint/tidy.git/ In my version of the package, the tidy binary is dynamically linked to libtidy.so.5 but the static version is also included for users that need it. I dropped the tidy-doc package as the upstream source no longer seems to build any docs other than the man page, although there are some Markdown files in the README directory of the upstream source which could potentially be included in a new tidy-doc package. The man page was included in the new tidy package, of course. |
On Wed, 15 Jun 2016 02:25:25 -0700
There is a pull request that adds these to tidy. Just include that
You have to basically merge subdirectory of tidy api in there as well, https://github.com/htacg/html-tidy.org.api specifically, the Personally, I think it was a mistake to move documentation generation |
Hi @AdamMajer, thanks for the patch! I'll wait to hear if Jason is pushing his package update, or is willing to work with collab-maint, before pushing further changes. Thanks also for the explanation about what happened to the docs. |
tidy5 has been accepted in Debian with one comment: |
Thanks @LudovicRousseau I hope that the upstream developers could explain further about the copyright. We have one serious bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827716 which I somehow overlooked. I am away from my development machine this week but could fix it after that, it's a one-liner. Also there are some bug tickets against the old package which could be tested and closed if someone would like to take a look at them: https://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=0;ordering=normal;repeatmerged=0;src=tidy-html5 |
Hi all, I am the missing Debian Developer, I've been busy for the last few years, working, getting married having kids. But things are getting less busy now and I'd like to continue maintaining tidy. I've already packages the current version and shared it with @AdamMajer, the link to my diff file is below. I'll take a look at your packaging and see if I missed anything. My package is already lintian clean. We need to look at package names and versions. https://www.dropbox.com/s/32lzjd8fqd8fo97/tidy_5.2.0-1.diff.gz?dl=0 |
Hello @jasonethomas. Welcome back. I think I/we made (a) mistake(s) with the upload of tidy. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828097 |
Hi @jasonethomas good to see you on here! I would strongly recommend that you take a look at https://anonscm.debian.org/cgit/collab-maint/tidy.git/ as a lot of work has been done there already. @LudovicRousseau there are of course some bugs flushed out by the new upload but the fixes seem straightforward. We can help with the library migration by fixing https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827891 which I am working on today. |
Hi @LudovicRousseau I have pushed a bunch of fixes to collab-maint today which fix the serious bugs on my test system. Please roll a 1:5.2.0-2 package when you are ready. |
@jasonethomas do you want to review+upload the new tidy version? |
Ondřej Surý already uploaded a new version of the package to fix #827716 and #827891. @danielhjames can you integrate the changes from 1:5.2.0-1.1 in the collab-maint project? |
Ondřej created a NEW git repository at http://anonscm.debian.org/cgit/collab-maint/tidy-html5.git/ :-( We need to add the git repository in
I have not made the change to not add more complexity to the merge of Ondřej changes. |
Hi @LudovicRousseau that seems like a reasonable solution since the git repo name now matches the source package. It's a pity that no-one emailed me before setting up a duplicate repo, but the important thing is that the new version of tidy is now in Debian and several people wish to help maintain it. |
Hi @danielhjames I just committed a couple of changes, to clean up and fix a bug. |
Thanks @jasonethomas ! I had wanted to use the version of the man page built from the source, but could not figure out the path to it. Other Debian Developers have set up a separate collab-maint project at http://anonscm.debian.org/cgit/collab-maint/tidy-html5.git/ which I'm also using now, so I will sync your changes there. Then to avoid confusion I think we should take the original project down. Would you like to be listed as the Maintainer: in debian/control again? |
Hi @jasonethomas I have prepared a 1:5.2.0-2 release in http://anonscm.debian.org/cgit/collab-maint/tidy-html5.git and changed the maintainer name/email back to yours in debian/control and debian/changelog. I'm happy to help with packaging via this collab-maint repo in future, should you need it. |
Hi @danieljames I believe a bunch of debian package use a collaborative grep Maintainer /var/lib/dpkg/available | grep Team | sort -ugrep Maintainer /var/lib/dpkg/available | grep Maintainers | sort -uIt might also be nice to have a "Debian.CREDITS" or similiar for Couple of other things:
What do you all think? On Wed, Jul 6, 2016 at 11:54 PM, Daniel James [email protected]
|
Hi @jasonethomas I think it's better if an official Debian Developer is listed as Maintainer, as I'm unable to release updates without sponsorship. I can still contribute (like others) via collab-maint. As for credits for packaging, one way to do this is to list maintainers in the debian/copyright file for Files: debian/* The docs were moved to a separate git repo upstream, therefore if we wish to reinstate the tidy-doc package we might need a separate source package for it. This might be a good opportunity to rename it, as there is a name clash with a different project: http://savannah.nongnu.org/projects/tidydoc/ #420 was already included in the package as a patch: http://anonscm.debian.org/cgit/collab-maint/tidy-html5.git/commit/?id=fa10ee7c30474ce103ccb23d7c327509dc121cea I don't think #421 is so relevant for packaging because we currently build tidy with the shared library anyway (I tested the /usr/bin/tidy binary to make sure), and we only provide the static library for special use cases. In general, as upstream is very responsive, I would like to suggest all known fixes go there, and that we only patch while awaiting an upstream release. Otherwise we have the situation of long-term patches where Debian's tidy is diverging from the upstream release, which can make QA more difficult. Cheers! Daniel |
Hi @geoffmcl I think this ticket could be closed now, we have a new official Debian package of 5.2.0 with lots of improvements from different people: http://metadata.ftp-master.debian.org/changelogs//main/t/tidy-html5/tidy-html5_5.2.0-2_changelog Thanks to @jasonethomas, @AdamMajer, @LudovicRousseau, Steve Langasek, Pino Toscano, Mattia Rizzolo, Gianfranco Costamagna and Ondřej Surý! |
On 07/07/2016 11:34 AM, Daniel James wrote:
There is an Uploaders entry for more than one person. https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Uploaders Typically for group maintenance, you have a common mailing address, like
|
@mcandre, @AdamMajer, @LudovicRousseau, @jasonethomas, as @danielhjames points out, we try to deal with issues promptly, so if I have missed something, please point it out to me... open/re-open an issue... thanks... But yes, it seems |
Any suggestions on how to upgrade if my system has the 2009 version? sudo apt-get remove tidy
sudo apt-cache autoclean
sudo apt-get install tidy still gives me the same outdated version :/ |
You should upgrade your system to Debian stretch or Ubuntu 18.04LTS |
@LudovicRousseau thanks, I will try that instead. |
No description provided.
The text was updated successfully, but these errors were encountered: