Skip to content

Bump old hls version and upgrade test runner to macos-latest #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Bump old hls version and upgrade test runner to macos-latest #960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f848483
Bump to ghc-8.10.7
July541 Sep 20, 2023
a01d0c6
Use macos latest
July541 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-11, ubuntu-latest, windows-latest]
ghc: [8.10.4, 8.10.7, 9.0.2, 9.2.8, 9.4.5, 9.6.2]
os: [macos-latest, ubuntu-latest, windows-latest]
ghc: [8.10.7, 9.0.2, 9.2.8, 9.4.7, 9.6.2]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
ghcup install ghc ${{matrix.ghc}}
ghcup set ghc ${{matrix.ghc}}

ghcup install hls 1.4.0
ghcup install hls 2.2.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is wrong because the test is supposed to test our ability to fallback to older HLS versions for unsupported GHC versions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since the next release drops support for 8.10.7, this will be correct again :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thinking that we may not merge big changes before the next hls release, it's not bad to write it here now.

ghcup install hls latest
shell: bash

Expand Down