Fix indentation of names starting with quotes #761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may interact badly with character literals. Can you add a test that
makes sure character literals are not affected?
|
|
If I may one more change: please two commits, one for functionality, one for tests. Reason is that if we need to revert functionality, we would like to keep the tests. |
|
@RafaelBocquet: This is a really useful change. There are at least two issues this fixes. Can you please split this commit into two and rebase on top of master? Humanity will be grateful. |
|
I've took your changes, rebased, added a test and created a pr #903. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #760.