Skip to content

Update emacs-snapshot source to ppa:ubuntu-elisp/ppa. #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2015
Merged

Update emacs-snapshot source to ppa:ubuntu-elisp/ppa. #477

merged 4 commits into from
Feb 28, 2015

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Feb 23, 2015

No description provided.

@gracjan
Copy link
Contributor Author

gracjan commented Feb 23, 2015

And we need fix for xref so that this compiles. @z0rch is working on this in #465.

@gracjan
Copy link
Contributor Author

gracjan commented Feb 26, 2015

Hmm, for Emacs25:

Running 3 tests (2015-02-26 16:01:25+0000)
Debugger entered: ((cl-assertion-failed (<= start end) nil))
cl--assertion-failed((<= start end))
haskell-indent-in-comment(38 13)

This test is expected to fail due to cl--assertion-failed, but that exception should be caught by ert. It should not trigger debugger.

How to make ert catch cl-assert as it used to?

@maximbaz
Copy link

@gracjan, yesterday I ran make EMACS=emacs-snapshot check on my branch in #465 (z0rch:459-find-tag-marker-ring-is-obsolete), and I got checks passed!.

I can have another look later today, perhaps it is the very recent snapshot that is failing.

@maximbaz
Copy link

Ah, no, perhaps more realistic idea is that my branch in #465 is based on earlier version of master rather than your branch here. Anyway, I'll have a look.

@gracjan
Copy link
Contributor Author

gracjan commented Feb 26, 2015

Internets are silent why cl-assert causes 'Debugger entered' even in batch mode. ERT should be able to catch it just like it did in Emacs 24.

@gracjan
Copy link
Contributor Author

gracjan commented Feb 26, 2015

@purcell?

@z0rch: thanks for help! Works now!

@gracjan
Copy link
Contributor Author

gracjan commented Feb 27, 2015

Now is much better, kludges removed.

purcell added a commit that referenced this pull request Feb 28, 2015
Update emacs-snapshot source to ppa:ubuntu-elisp/ppa.
@purcell purcell merged commit 5c75b88 into haskell:master Feb 28, 2015
@purcell
Copy link
Member

purcell commented Feb 28, 2015

All looks good to me. Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants