Add hayoo backend for suggesting imports.

[alexanderkjeldaas]

NixOS doesn't seem to have a working hoogle, so hayoo is the better option. Added a hayoo backend.

[purcell]

Wouldn't the standard mapcar be equivalent here?

[alexanderkjeldaas]

I can use cl-mapcan, but I also need to convert from vector to list (using append x nil).

However, I see another problem here. There is no queuing when asking the user for a response, so when multiple symbols are missing, they seem to be all over each other asking whether to add an import statement.

Some kind of explicit queuing seems to be needed when the prompt is called asyncronously.

[purcell]

lexical-let might be an option here, right, since these vars are local to this function and its nested lambdas?

[alexanderkjeldaas]

Yes that seems to work. Thanks!

[purcell]

There's a build failure with the current version of this PR:

In toplevel form:

haskell-process.el:935:56:Error: `(session session)' is a malformed function

make: *** [check-haskell-process] Error 1

You can run make check locally to reproduce this, or make check EMACS=/my/path/to/emacs if necessary.

[alexanderkjeldaas]

Fixed. And thanks for the 'make check' tip.

We now require 'cl during compilation until the code is converted to use
lexical bindings by default (Emacs 24.1+)

On Thu, Oct 16, 2014 at 10:11 AM, Steve Purcell [email protected]
wrote:

There's a build failure with the current version of this PR:

In toplevel form:

haskell-process.el:935:56:Error: `(session session)' is a malformed function

make: *** [check-haskell-process] Error 1

You can run make check locally to reproduce this, or make check
EMACS=/my/path/to/emacs if necessary.

—
Reply to this email directly or view it on GitHub
#358 (comment).

[purcell]

We only just removed 'cl everywhere: I think we can keep things simple and just fetch the hayoo results synchronously in this case. I made a couple of further commits on a branch of my own to show what I mean: https://github.com/purcell/haskell-mode/compare/hayoo?expand=1

Let me know if that makes sense, and I'll go ahead and squash then apply everything here.

[alexanderkjeldaas]

Looks good to me.

[purcell]

Squashed and merged! Thanks for all your work on this.

[gracjan]

@purcell: close?