Extend static completions with candidates from tags table #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. |
gracjan
added a commit
that referenced
this pull request
Mar 22, 2016
…ions Extend static completions with candidates from tags table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1184
I thought to add
tags-completion-at-point-functiontocompletion-at-point-functionshook at first, but this approach is not good enough because in this case completion functions are run sequentially and candidates are not merged. So, if haskell completion function will go first and it is able to complete thing at point there is no candidates from tags and vice versa. And it is not clear what function should go first.Fortunately, I've discovered
tags-completion-tablefunction, with it now it's possible to merge tags completions with keyword completions.One question: should we revisit tags table automatically when it is regenerated (in
haskell-mode-generate-tags)?