Highlighting of data types is broken

[mrkkrp]

Now it somehow uses font-lock-function-name-face or something visually similar instead of font-lock-type-face.

[mrkkrp]

Now highlighting does not quite work and indentation is still not working for me (even that bare minimum that used to work). I'm beginning to think that haskell-mode is just getting worse and worse. Perhaps soon it will be completely unusable. You publish monthly reports with some words in them, but I'm not going to be excited about that when most basic functionality suffers such degradation. Can you at least perform some manual testing before pushing?

---

I hate to be negative, but the dynamic of haskell-mode development scares me.

[mrkkrp]

↑ Here, every capitalized word should be orange, now they are highlighted seemingly randomly. Can we get proper highlighting back?

[geraldus]

I think that idea (to distinguish module names, type constructors, value constructors, and maybe class names from each other) is good and reasonable itself.

[mrkkrp]

Well, maybe. But now we've got a lot of different things that are colored the same way (identifiers and type-level things for example). I find this harder to read.

[geraldus]

I agree the algorithm should be fixed. Coloured code is a matter of choice, there are people who find monochrome code is much readable.

[gracjan]

Types are colored using haskell-type-face. Place change it to the color of your liking.

[mrkkrp]

Why not use standard font-lock collection of faces that are defined in all color themes nicely? Do you expect me to tune this stuff myself? I set up a theme and then open a Haskell source and it should look OK, just like in every other mode (what a nightmare would it be if every major mode used its own collection of faces when there is a conventional set of font-lock- ones?). No? Quasi-quotes also look strange (not highlighted at all, it seems).

No issue that I reported here has been fixed properly and note that all this stuff generally worked well in the past. Maybe we didn't have indentation enabled out-of-box, but it worked much better in simplest cases. Now it does not work and I'm doing all indentation manually or with special editing commands I wrote myself. In addition to this, you say I'm going to have troubles and custom arrangements even with basic highlighting?

[mrkkrp]

↑ I'm just trying to understand how to work with this without feeling like I'm messing with something absolutely broken.

[ivan-m]

I think QuasiQuotes are done by trying to font-lock according to a mode by assuming that the quasiquoter used is the same as the name of a mode. I think if a mode isn't found though that it should just default to being the same as a String.

[gracjan]

@mrkkrp: I see only three issues reported by you and not closed #870, #1180 and this one.

QuasiQuotes are colorized like the respective mode. There is a bug when colorization gets in the way, it is tracked by tests case here: https://github.com/haskell/haskell-mode/blob/master/tests/haskell-font-lock-tests.el#L378

haskell-type-face has wrong default font-lock-function-name-face, should be font-lock-type-face and I suppose this is the real bug you are talking about here.

Please discuss indentation in #1178.

[mrkkrp]

“QuasiQuotes are colorized like the respective mode” — cool, but I've got a mode for hamlet templates and it doesn't seem to work here.

[gracjan]

How is it called?