Skip to content

Remove ghcide-test-utils as a separate package #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
os: ${{ runner.os }}

- name: Build
run: cabal build
run: cabal build all

- name: Set test options
# See https://github.com/ocharles/tasty-rerun/issues/22 for why we need
Expand Down
1 change: 0 additions & 1 deletion cabal.project
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ packages:
./hls-graph
./ghcide
./ghcide-bench
./ghcide/test
./hls-plugin-api
./hls-test-utils

Expand Down
3 changes: 1 addition & 2 deletions ghcide-bench/ghcide-bench.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ library
directory,
extra,
filepath,
ghcide,
ghcide-test-utils,
ghcide:{ghcide, ghcide-test-utils},
hashable,
lens,
lsp-test,
Expand Down
42 changes: 37 additions & 5 deletions ghcide/ghcide.cabal
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cabal-version: 3.0
cabal-version: 3.4
build-type: Simple
category: Development
name: ghcide
Expand Down Expand Up @@ -280,6 +280,40 @@ executable ghcide
if !flag(executable)
buildable: False

library ghcide-test-utils
import: warnings
visibility: public
default-language: GHC2021

hs-source-dirs: test/src test/cabal
exposed-modules:
Development.IDE.Test
Development.IDE.Test.Runfiles
Development.IDE.Test.Diagnostic

build-depends:
aeson,
base > 4.9 && < 5,
containers,
data-default,
directory,
extra,
filepath,
ghcide,
lsp-types,
hls-plugin-api,
lens,
lsp-test ^>= 0.17,
tasty-hunit >= 0.10,
text,
row-types,

default-extensions:
LambdaCase
OverloadedStrings
RecordWildCards
ViewPatterns

test-suite ghcide-tests
import: warnings
type: exitcode-stdio-1.0
Expand All @@ -301,6 +335,7 @@ test-suite ghcide-tests
, filepath
, fuzzy
, ghcide
, ghcide:ghcide-test-utils
, hls-plugin-api
, lens
, list-t
Expand Down Expand Up @@ -330,7 +365,7 @@ test-suite ghcide-tests
if impl(ghc <9.3)
build-depends: ghc-typelits-knownnat

hs-source-dirs: test/cabal test/exe test/src
hs-source-dirs: test/exe
ghc-options: -threaded -O0

main-is: Main.hs
Expand All @@ -343,9 +378,6 @@ test-suite ghcide-tests
CPPTests
CradleTests
DependentFileTest
Development.IDE.Test
Development.IDE.Test.Diagnostic
Development.IDE.Test.Runfiles
DiagnosticTests
ExceptionTests
FindDefinitionAndHoverTests
Expand Down
50 changes: 0 additions & 50 deletions ghcide/test/ghcide-test-utils.cabal

This file was deleted.

32 changes: 19 additions & 13 deletions haskell-language-server.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ flag dynamic
default: True
manual: True

----------------------------
----------------------------
-- PLUGINS
----------------------------
----------------------------

-----------------------------
-- cabal-fmt plugin
-----------------------------
Expand Down Expand Up @@ -326,8 +332,8 @@ test-suite hls-call-hierarchy-plugin-tests
, extra
, filepath
, haskell-language-server:hls-call-hierarchy-plugin
, hls-test-utils == 2.6.0.0
, ghcide-test-utils
, hls-test-utils == 2.6.0.0
, ghcide:ghcide-test-utils
, lens
, lsp
, lsp-test
Expand Down Expand Up @@ -459,7 +465,7 @@ test-suite hls-explicit-imports-plugin-tests
, extra
, filepath
, haskell-language-server:hls-explicit-imports-plugin
, hls-test-utils
, hls-test-utils == 2.6.0.0
, lens
, lsp-types
, row-types
Expand Down Expand Up @@ -1194,7 +1200,7 @@ test-suite hls-explicit-record-fields-plugin-tests
, filepath
, text
, haskell-language-server:hls-explicit-record-fields-plugin
, hls-test-utils
, hls-test-utils == 2.6.0.0

-----------------------------
-- overloaded record dot plugin
Expand Down Expand Up @@ -1238,7 +1244,7 @@ test-suite hls-overloaded-record-dot-plugin-tests
, filepath
, text
, haskell-language-server:hls-overloaded-record-dot-plugin
, hls-test-utils
, hls-test-utils == 2.6.0.0


-----------------------------
Expand Down Expand Up @@ -1511,8 +1517,7 @@ test-suite hls-refactor-plugin-tests
, parser-combinators
, data-default
, extra
, ghcide
, ghcide-test-utils
, ghcide:{ghcide, ghcide-test-utils}
, shake
, hls-plugin-api
, lsp-test
Expand Down Expand Up @@ -1589,7 +1594,7 @@ test-suite hls-semantic-tokens-plugin-tests
, filepath
, haskell-language-server:hls-semantic-tokens-plugin
, hls-test-utils == 2.6.0.0
, ghcide-test-utils
, ghcide:ghcide-test-utils
, hls-plugin-api
, lens
, lsp
Expand All @@ -1602,9 +1607,11 @@ test-suite hls-semantic-tokens-plugin-tests
, data-default
, row-types

-----------------------------
----------------------------
----------------------------
-- HLS
-----------------------------
----------------------------
----------------------------

library
import: defaults
Expand Down Expand Up @@ -1763,8 +1770,7 @@ test-suite func-test
, deepseq
, extra
, filepath
, ghcide
, ghcide-test-utils
, ghcide:{ghcide, ghcide-test-utils}
, hashable
, hls-plugin-api
, hls-test-utils == 2.6.0.0
Expand Down Expand Up @@ -1812,7 +1818,7 @@ test-suite wrapper-test
build-depends:
, base >=4.16 && <5
, extra
, hls-test-utils
, hls-test-utils == 2.6.0.0
, process

hs-source-dirs: test/wrapper
Expand Down
1 change: 0 additions & 1 deletion stack-lts21.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ packages:
- ./hie-compat
- ./hls-graph
- ./ghcide/
- ./ghcide/test
- ./hls-plugin-api
- ./hls-test-utils
# - ./shake-bench
Expand Down
1 change: 0 additions & 1 deletion stack.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ packages:
- ./hie-compat
- ./hls-graph
- ./ghcide/
- ./ghcide/test
- ./hls-plugin-api
- ./hls-test-utils
# - ./shake-bench
Expand Down