Skip to content

Expose makeDefaultHandleRecorder #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2023
Merged

Expose makeDefaultHandleRecorder #3485

merged 1 commit into from
Feb 12, 2023

Conversation

ners
Copy link
Contributor

@ners ners commented Feb 10, 2023

I am trying to run HLS/Ghcide without giving it stdin/stdout/stderr. We can currently redirect stdout and stderr by passing appropriate values in Arguments.argsHandleIn and argsHandleOut, but we can't redirect the recorder anywhere but stderr.

@ners ners requested a review from pepeiborra as a code owner February 10, 2023 08:40
fendor
fendor approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpj michaelpj enabled auto-merge (squash) February 12, 2023 16:04
@michaelpj michaelpj merged commit d3a5ee1 into haskell:master Feb 12, 2023
wz1000 pushed a commit that referenced this pull request Mar 14, 2023
@ners @wz1000
Expose makeDefaultHandleRecorder (#3485)
4a7ad18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ners @fendor @michaelpj