Skip to content

Make eval plugin work at ghc 9.4 #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

dyniec
Copy link
Contributor

@dyniec dyniec commented Oct 9, 2022

This is work in progress, but it works(given issues below) :)
It will not compile for older ghc version, and so far it doesn't handle unit ids at all.
It is hardcoded for package "blah" version 0.1.0.0 now. Proper solutions for those issues will show up in separate commits

It will need rebase when #3249 lands.

Leaving it as draft until I get it to a better state

@dyniec
Copy link
Contributor Author

dyniec commented Oct 9, 2022

Fixed hardcoded package name and adaded ifdefs guarding differences between 9.2 and 9.4.
When I manage to confirm it works on earlier versions (8.8 and maybe 8.6?) I will either mark it as ready to review or patch this as well

@michaelpj
Copy link
Collaborator

8.8 and maybe 8.6?

We just dropped support for 8.6 and 8.8 is going to be dropped soon, so don't bother. Does 8.10 work?

@pepeiborra
Copy link
Collaborator

Don't forget enabling the testsuite in the test.yml file.

This is work in progress, it will likely not compile for older ghc
version, and so far it doesn't handle unit ids at all.
It is hardcoded for package "blah" version 0.1.0.0 now.
Proper solutions for those issues will show up in separate commits
Also makes code compile (and still work) on ghc 9.2.
@dyniec
Copy link
Contributor Author

dyniec commented Oct 14, 2022

Ghc 8.10.7 seems to still work fine. Rebased on top of main commit, and enabled tests. I updated some tests for ghc94, but I have 6 left failing due to a difference in error format. I will try to figure that out over the weekend
Examples:

    expected: Just "-- Variable not in scope: noFunctionWithThisName"
     but got: Just "-- /home/dyniec/projects/haskell-language-server/plugins/hls-eval-plugin/test/testdata/T8.hs:2:2: error:\n--     Variable not in scope: noFunctionWithThisName"

and

    --- Not in scope: type variable `a'
    +-- <interactive>:1:1: error: Not in scope: type variable `a'

@July541 July541 mentioned this pull request Oct 15, 2022
34 tasks
@dyniec dyniec closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants