added completion for language to { -# LANGUAGE

[alexnaspo]

fixes #681

[pepeiborra]

I'm not sure what's going on here, but we already have completions for pragmas and they seem to work for me:

haskell-language-server/ghcide/src/Development/IDE/Plugin/Completions/Logic.hs

Lines 658 to 671 in 868e476

	validPragmas :: [(T.Text, T.Text)]
	validPragmas =
	[ ("LANGUAGE ${1:extension}" , "LANGUAGE")
	, ("OPTIONS_GHC -${1:option}" , "OPTIONS_GHC")
	, ("INLINE ${1:function}" , "INLINE")
	, ("NOINLINE ${1:function}" , "NOINLINE")
	, ("INLINABLE ${1:function}" , "INLINABLE")
	, ("WARNING ${1:message}" , "WARNING")
	, ("DEPRECATED ${1:message}" , "DEPRECATED")
	, ("ANN ${1:annotation}" , "ANN")
	, ("RULES" , "RULES")
	, ("SPECIALIZE ${1:function}" , "SPECIALIZE")
	, ("SPECIALIZE INLINE ${1:function}", "SPECIALIZE INLINE")
	]

Perhaps you could look into refining the existing completion snippet so that it inserts the pragma close tokens #-} and/or characterise whether it works in all situations?

Screen.Recording.2021-08-28.at.12.23.02.mov

[alexnaspo]

@pepeiborra - sure I can take a look at that. Do you think I should move the auto completions into the pragmas plugin?

The difference here is that it auto completes on "language" rather than "{-# LANGUAGE" as the ticket requests

[ndmitchell]

Haskell is case-insensitive for its pragmas, so lAnGuAgE works just fine. Perhaps the completions module just needs to be educated to that fact?

[pepeiborra]

@pepeiborra - sure I can take a look at that. Do you think I should move the auto completions into the pragmas plugin?

That would be great

[alexnaspo]

@pepeiborra - sure I can take a look at that. Do you think I should move the auto completions into the pragmas plugin?

That would be great

I opened up a separate PR because it no longer closes the above ticket @pepeiborra
#2134

[jneira]

@alexnaspo so could we close this one, as it is included in #2134 iiuc?