Skip to content

Duplicate pragma warnings fixed #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ishmum123
Copy link
Contributor

@ishmum123 ishmum123 commented Feb 9, 2021

Closes #798

@ishmum123 ishmum123 changed the title Duplicate pragma warnings fixed (#798) Duplicate pragma warnings fixed Feb 9, 2021
@jneira
Copy link
Member

jneira commented Feb 9, 2021

Thanks for opening it even if we merge #1334 although i feel a little bit sad for your somewhat wasted work if finally that is the case.
Maybe an initial draft pr would have make easier leverage your work even sharing the authoring with other collaborators.

@ishmum123
Copy link
Contributor Author

@jneira thanks for being so considerate. Don't worry about it. I think of this fix as a way of dipping into the codebase. Also, yes I understand the mistake I made. Would learn from it hopefully. :D

@jneira
Copy link
Member

jneira commented Feb 9, 2021

Closed in favor of #1334

@jneira jneira closed this Feb 9, 2021
@jneira
Copy link
Member

jneira commented Feb 9, 2021

Don't worry about it. I think of this fix as a way of dipping into the codebase. Also, yes I understand the mistake I made. Would learn from it hopefully

Yeah, i hope you can contribute to the repo in some other way. Open a draft pr doesnt ensure it will not be closed as the alternative can be so different that it does not worth to change the existing one. But sometimes the discussion itself over existing code helps to readjust it and signal other devs someone is working on it.

@berberman
Copy link
Collaborator

@ishmum123 There is another issue about pragmas you may have an interest in :)

I think you can refer to endOfModuleHeader introduced by #1235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record quick fixes based on fields should be deduped
3 participants