textDocument/definition not working

[dewijones92]

Your environment

Which OS do you use:
POP OS

haskell LSP server version
ce41b6459af131c845f942bd39e356f02b6306fa master, tag: 1.6.0.0

Which LSP client (editor/plugin) do you use:
emacs

Describe your project (alternative: link to the project):
stack.yaml

Steps to reproduce

Hover over noto on line 16 and try to go to it's definition
In this file https://github.com/dewijones92/helloworld/blob/master/app/Main.hs

Expected behaviour

Cursour should go to line 9 where noto is defined

Actual behaviour

nothing - the lsp server does not return the function definition location

Include debug information

[Trace - 10:51:17 PM] Sending request 'textDocument/definition - (200)'.                                                                                                                                                               
Params: {                                                                                                                                                                                                                              
  "textDocument": {                                                                                                                                                                                                                    
    "uri": "file:///home/dewi/tmp/haskellTut/helloworld/Setup.hs"                                                                                                                                                                      
  },                                                                                                                                                                                                                                   
  "position": {                                                                                                                                                                                                                        
    "line": 15,                                                                                                                                                                                                                        
    "character": 13                                                                                                                                                                                                                    
  }                                                                                                                                                                                                                                    
}                                                                                                                                                                                                                                      
                                                                                                                                                                                                                                       
                                                                                                                                                                                                                                       
[Trace - 10:51:17 PM] Received response 'textDocument/definition - (200)' in 1ms.                                                                                                                                                      
Result: []   

[dewijones92]

not sure if I am missing something?

[drsooch]

Go to definition appears to be working fine for me. Can you produce a minimal reproduction i.e. an actual file to test on?

[dewijones92]

@drsooch
I updated the post
thanks

[drsooch]

[Trace - 11:04:29 AM] Sending request 'textDocument/definition - (54)'.
Params: {
  "textDocument": {
    "uri": "file:///home/user/code/haskell/helloworld/app/Main.hs"
  },
  "position": {
    "line": 12,
    "character": 11
  }
}


[Trace - 11:04:29 AM] Received response 'textDocument/definition - (54)' in 1ms.
Result: [
  {
    "range": {
      "end": {
        "character": 4,
        "line": 6
      },
      "start": {
        "character": 0,
        "line": 6
      }
    },
    "uri": "file:///home/user/code/haskell/helloworld/app/Main.hs"
  }
]

Seems to work for me.

[drsooch]

Could have something to do with using Setup.hs as your file but someone else more knowledgeable than I may have a better clue.

[dewijones92]

@drsooch
I have just tried in Main.hs

https://github.com/dewijones92/helloworld/blob/master/app/Main.hs

FYI it compiles and runs fine

dewi@pop-os:~/tmp/haskellTut/helloworld$ stack build && stack exec helloworld-exe
Example of Haskell Function composition
"This is an ODD number"
"This is an even Number"
dewi@pop-os:~/tmp/haskellTut/helloworld$

But the go to definition does not work

[Trace - 04:26:59 PM] Sending request 'textDocument/definition - (242)'.                                                                                                                                                               
Params: {                                                                                                                                                                                                                              
  "textDocument": {                                                                                                                                                                                                                    
    "uri": "file:///home/dewi/tmp/haskellTut/helloworld/app/Main.hs"                                                                                                                                                                   
  },                                                                                                                                                                                                                                   
  "position": {                                                                                                                                                                                                                        
    "line": 13,                                                                                                                                                                                                                        
    "character": 13                                                                                                                                                                                                                    
  }                                                                                                                                                                                                                                    
}                                                                                                                                                                                                                                      
                                                                                                                                                                                                                                       
                                                                                                                                                                                                                                       
[Trace - 04:26:59 PM] Received response 'textDocument/definition - (242)' in 1ms.                                                                                                                                                      
Result: []                                                                                                                                                                                                                             
              

[drsooch]

Can you check your HLS logs when attempting to goto definition?

[dewijones92]

#2654 (comment)

@drsooch here?

[drsooch]

should be in /tmp/hls.log that's the server trace

[michaelpj]

Please consult the troubleshooting section in the documentation also.

[dewijones92]

@drsooch
These logs aren't that insightful 🤔

2022-01-29 18:38:11.281779619 [ThreadId 3449] DEBUG hls:        finish: C:GetHieAst:/home/dewi/tmp/haskellTut/helloworld/app/Main.hs (took 0.00s)
2022-01-29 18:38:11.281786852 [ThreadId 3452] INFO hls: finish: Pragmas.GhcSession (took 0.00s)
2022-01-29 18:38:11.281842936 [ThreadId 3455] INFO hls: finish: Pragmas.GetFileContents (took 0.00s)
2022-01-29 18:38:11.281870477 [ThreadId 3456] INFO hls: finish: Pragmas.GetParsedModule (took 0.00s)
2022-01-29 18:38:46.340739481 [ThreadId 5] INFO hls:    Live bytes: 0.00MB Heap size: 0.00MB
2022-01-29 18:39:46.40190425 [ThreadId 5] INFO hls:     Live bytes: 0.00MB Heap size: 0.00MB
2022-01-29 18:40:46.462753075 [ThreadId 5] INFO hls:    Live bytes: 0.00MB Heap size: 0.00MB
2022-01-29 18:41:46.523554105 [ThreadId 5] INFO hls:    Live bytes: 0.00MB Heap size: 0.00MB
2022-01-29 18:42:46.584590802 [ThreadId 5] INFO hls:    Live bytes: 0.00MB Heap size: 0.00MB
2022-01-29 18:43:46.645613114 [ThreadId 5] INFO hls:    Live bytes: 0.00MB Heap size: 0.00MB










2022-01-29 18:44:46.706363789 [ThreadId 5] INFO hls:    Live bytes: 0.00MB Heap size: 0.00MB
2022-01-29 18:44:48.66398958 [ThreadId 3460] DEBUG hls: Definition request at position 13:17 in file: /home/dewi/tmp/haskellTut/helloworld/app/Main.hs
2022-01-29 18:44:48.664245704 [ThreadId 3461] DEBUG hls:        finish: C:GetHieAst:/home/dewi/tmp/haskellTut/helloworld/app/Main.hs (took 0.00s)
2022-01-29 18:44:49.170494099 [ThreadId 3477] INFO hls: finish: RefineImports (took 0.00s)
2022-01-29 18:44:49.170540946 [ThreadId 3476] INFO hls: finish: importLens (took 0.00s)
2022-01-29 18:44:49.170460367 [ThreadId 3474] INFO hls: finish: GhcideCodeActions.getParsedModule (took 0.00s)
2022-01-29 18:44:49.170576822 [ThreadId 3475] INFO hls: finish: QualifyImportedNames.TypeCheck (took 0.00s)
2022-01-29 18:44:49.17059158 [ThreadId 3478] INFO hls:  finish: Pragmas.GhcSession (took 0.00s)
2022-01-29 18:44:49.17066731 [ThreadId 3479] INFO hls:  finish: Pragmas.GetFileContents (took 0.00s)
2022-01-29 18:44:49.170677078 [ThreadId 3480] INFO hls: finish: Pragmas.GetParsedModule (took 0.00s)
2022-01-29 18:44:49.170772845 [ThreadId 3483] DEBUG hls:        DocumentHighlight request at position 13:17 in file: /home/dewi/tmp/haskellTut/helloworld/app/Main.hs
2022-01-29 18:44:49.171031434 [ThreadId 3485] DEBUG hls:        finish: C:GetHieAst:/home/dewi/tmp/haskellTut/helloworld/app/Main.hs (took 0.00s)

[dewijones92]

Does anybody have any idea?
thanks