Skip to content

Upgrade to stack 3.3.1 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Upgrade to stack 3.3.1 #154

merged 1 commit into from
May 14, 2025

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented May 9, 2025

.. which is now the ghcup - recommended version to use

@jhrcek jhrcek force-pushed the jhrcek/stack-3.3.1 branch from 3cfd12a to 4449d2b Compare May 9, 2025 15:45
@jhrcek jhrcek marked this pull request as ready for review May 9, 2025 17:01
@jhrcek jhrcek requested review from Copilot and develop7 and removed request for Copilot May 9, 2025 17:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Stack version to 3.3.1, which is now the recommended ghcup version.

  • Update the ARG STACK value from 3.1.1 to 3.3.1.
  • Update corresponding SHA256 checksum values for both 'aarch64' and 'x86_64' architectures.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
9.8/slim-bullseye/Dockerfile Upgraded Stack version and updated SHA256 checksums.
9.8/bullseye/Dockerfile Upgraded Stack version and updated SHA256 checksums.
9.6/slim-bullseye/Dockerfile Upgraded Stack version and updated SHA256 checksums.
9.6/bullseye/Dockerfile Upgraded Stack version and updated SHA256 checksums.
9.10/slim-bullseye/Dockerfile Upgraded Stack version and updated SHA256 checksums.
9.10/bullseye/Dockerfile Upgraded Stack version and updated SHA256 checksums.
Comments suppressed due to low confidence (12)

9.8/slim-bullseye/Dockerfile:26

  • Ensure the upgraded Stack version (3.3.1) is intentional and in line with ghcup recommendations. Consider adding a comment linking to the official release notes for future reference.
+ARG STACK=3.3.1

9.8/slim-bullseye/Dockerfile:36

  • Verify that the updated SHA256 checksum for the 'aarch64' architecture correctly corresponds to Stack 3.3.1. Including the source URL for the checksum can aid maintainability.
+            STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';

9.8/bullseye/Dockerfile:26

  • Ensure the upgraded Stack version (3.3.1) is intentional and documented. Consider adding a reference comment to the official release notes.
+ARG STACK=3.3.1

9.8/bullseye/Dockerfile:36

  • Verify that the updated SHA256 checksum for the 'aarch64' architecture is correct for Stack 3.3.1. A comment with the checksum source can help future reviews.
+            STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';

9.6/slim-bullseye/Dockerfile:26

  • Confirm that the upgrade to Stack 3.3.1 is deliberate and that related documentation is updated accordingly. Linking to release notes might improve clarity.
+ARG STACK=3.3.1

9.6/slim-bullseye/Dockerfile:36

  • Ensure that the SHA256 checksum update for 'aarch64' is correct for the new Stack version. Adding a reference to the checksum source may help maintainability.
+            STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';

9.6/bullseye/Dockerfile:26

  • Double-check that the update to Stack 3.3.1 is intended and aligns with upstream recommendations. A brief comment with the release reference could be beneficial.
+ARG STACK=3.3.1

9.6/bullseye/Dockerfile:36

  • Verify that the updated SHA256 checksum for the 'aarch64' architecture is sourced from the official Stack 3.3.1 release. Including this reference as a comment may aid future maintenance.
+            STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';

9.10/slim-bullseye/Dockerfile:26

  • Ensure the update to Stack 3.3.1 is intentional and that any related documentation is updated. A comment with a link to the release notes would be helpful.
+ARG STACK=3.3.1

9.10/slim-bullseye/Dockerfile:36

  • Make sure the new SHA256 checksum for 'aarch64' is accurate for Stack 3.3.1. Including the official checksum source as a comment is recommended for clarity.
+            STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';

9.10/bullseye/Dockerfile:26

  • Confirm that the change to Stack 3.3.1 is correct and that related documentation reflects this update. A reference comment for the official release notes could be useful.
+ARG STACK=3.3.1

9.10/bullseye/Dockerfile:36

  • Ensure the updated SHA256 checksum for 'aarch64' matches the official value for Stack 3.3.1. Adding a comment with the source of this checksum can improve maintainability.
+            STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';

Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I've missed it

@develop7 develop7 self-requested a review May 14, 2025 04:25
@develop7 develop7 merged commit 9f6ddaa into master May 14, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants