Skip to content

CI for building doc with sphinx #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Sep 11, 2021

Simplified from agda/agda/.github/workflows/user-manual.yml

Simple minded. Builds doc by

  • installing python
  • make users-guide
  • upload-artifact

Maybe something more sophisticated could be done later where we push to ghpages or something.

Tested by downloading the artifact and having a rough look.

See new job Users guide in the checks below. Should maybe also switched to "Required".

Simplified from agda/agda/.github/workflows/user-manual.yml
@Mikolaj
Copy link
Member

Mikolaj commented Sep 11, 2021

Amazing. Yes, given our experiences, I think doc building should be required.

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This should be subsumed by readthedocs' pull request integration, but until we figure out what's blocking it, it makes sense to have this.

@Mikolaj
Copy link
Member

Mikolaj commented Sep 13, 2021

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2021

Command rebase: failure

Pull request can't be updated with latest base branch changes
GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed.
This pull request must be rebased manually.
err-code: DC736

@Mikolaj Mikolaj added merge me Tell Mergify Bot to merge and removed attention: needs-review merge me Tell Mergify Bot to merge labels Sep 13, 2021
@Mikolaj Mikolaj merged commit d7a2add into haskell:master Sep 13, 2021
@Mikolaj
Copy link
Member

Mikolaj commented Sep 13, 2021

I abused my privilege to cut the CI race condition. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants