Skip to content

Add regression test for #5782, which requires extending test harness to v2-install #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2021

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented May 17, 2021

This adds a regression test for #5782.

I've extended cabal-testsuite harness to exes taken from v2-install (it assumed in-place install, as in v2-build, so AFAICT no amount of extra flags would help). And there is a separate issue that for cabal <= 3.2 my test requires a dummy --installdir option, but I hope we don't run regtression tests with old cabals? Otherwise it would fail anyway, because the test fails in cabal 3.2, being a regression test for an issue fixed (for good) in 3.4


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@Mikolaj Mikolaj requested a review from fgaz May 17, 2021 07:57
@Mikolaj
Copy link
Member Author

Mikolaj commented May 17, 2021

@fgaz: I bet I missed some thing one needs to do with a new test, like disable it for too old cabals, etc. Any hints appreciated, especially as checks fail...

@Mikolaj Mikolaj force-pushed the master branch 3 times, most recently from ef57a08 to 855be09 Compare May 20, 2021 20:25
@Mikolaj
Copy link
Member Author

Mikolaj commented May 21, 2021

This is now ready for review.

The only failing CI test is continuous-integration/appveyor/pr where I'm consistently getting 'heap exhauted' failures, e.g., https://ci.appveyor.com/project/23Skidoo/cabal/builds/39255946 but the PR can't be causing that, so it's unrelated.

BTW, I don't have admin access to the AppVeyor CI and so can't, e.g., restart it; I wonder if it should be somehow granted based on github roles.

BTW2, the 'Checks' menu of github doesn't know about AppVeyor --- are any other tests not present there? I guess this can't be easily fixed (no clue about github CI and UI).

@Mikolaj Mikolaj requested a review from emilypi May 21, 2021 11:54
@Mikolaj
Copy link
Member Author

Mikolaj commented May 21, 2021

@jneira: would you add a quick review, given that this affair is based in part on your findings?

@jneira
Copy link
Member

jneira commented May 22, 2021

Hi, thanks for the mention (and the invitation! 😄 )
The test looke totally reasonable, to have a case of a diamond dependency seems to be good even if no there was not real bug before.

@Mikolaj Mikolaj requested a review from jneira May 24, 2021 09:23
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for take care of the possible regression

@Mikolaj
Copy link
Member Author

Mikolaj commented May 24, 2021

@jneira: thank you for the review and your reports and troubleshooting.

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj
Copy link
Member Author

Mikolaj commented May 24, 2021

I've rebased and the CI failure about heap exhausted vanished, which proves it was caused by the state of master branch at that time (rummaging in CI history seems to confirm that). Right now I'm getting MacOS failures, in turn, but surely not my fault either --- probably an outage of wherever we are taking the MacOS archives from.

@fgaz, @phadej: I will merge as soon as you say 'go' or I get bored waiting. :)

@emilypi
Copy link
Member

emilypi commented May 24, 2021

@Mikolaj go

@Mikolaj
Copy link
Member Author

Mikolaj commented May 24, 2021

I go.

@Mikolaj Mikolaj merged commit 78fbe09 into haskell:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants