-
Notifications
You must be signed in to change notification settings - Fork 712
Cabal 3.14.2 depends on Cabal-syntax at least 3.14.2 #10917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Would be great to discuss at one point how to avoid such slips in the future... |
check-sdist is supposed to catch these, but currently (a) only considers |
Looks like we have a plan -- good! I'm thinking about adding something to the Wiki page anyway. The best place I see is:
I'm not sure why it lists "secondary" packages, which we don't publish, like
Thouths? |
I think the ones it lists are the ones that are usually forgotten even in major versions, whereas this case only happens when we have unexpected API changes in minor versions. |
@geekosaur, thanks for clarifying! I added a little phrase there so that it doesn't sound like it's only about aux packages (which it sounded to me like that before). |
Should this be forward ported to |
@ffaf1 I was thinking about it. It's not clear to me that it should. Master has 3.15 everywhere, I think. When 3.16 will be cut, we must make sure that dependencies are handled accordingly. But I'm not sure we want 3.14.2 for version bound on master. |
Ah, right, you've just reminded me why it wasn't forward-ported in the first place. |
fix #10916
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: