Skip to content

Cabal 3.14.2 depends on Cabal-syntax at least 3.14.2 #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

ulysses4ever
Copy link
Collaborator

fix #10916


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Apr 9, 2025
@mergify mergify bot merged commit 0f82880 into 3.14 Apr 9, 2025
57 checks passed
@mergify mergify bot deleted the fix-issue10916 branch April 9, 2025 10:35
@ulysses4ever
Copy link
Collaborator Author

Would be great to discuss at one point how to avoid such slips in the future...

@geekosaur
Copy link
Collaborator

check-sdist is supposed to catch these, but currently (a) only considers Cabal, not Cabal-syntax (b) got broken by a PVP-acceptable API change it doesn't currently support. Rewriting it is on the menu.

@ulysses4ever
Copy link
Collaborator Author

ulysses4ever commented Apr 9, 2025

Looks like we have a plan -- good! I'm thinking about adding something to the Wiki page anyway. The best place I see is:

C.3.2 Change the dependency constraints on Cabal-syntax and Cabal to the new version where they are needed in the repo (like cabal-testsuite/cabal-testsuite.cabal and bootstrap/cabal-bootstrap-gen.cabal).

I'm not sure why it lists "secondary" packages, which we don't publish, like cabal-testsuite and doesn't mention the main packages that we do publish. In any case, this item already has a sublist with one item, and I want to add another one:

Sometimes this means updating the lower bounds too, even for minor releases (to avoid issues like #10916 and #9833).

Thouths?

@geekosaur
Copy link
Collaborator

I think the ones it lists are the ones that are usually forgotten even in major versions, whereas this case only happens when we have unexpected API changes in minor versions.

@ulysses4ever
Copy link
Collaborator Author

@geekosaur, thanks for clarifying! I added a little phrase there so that it doesn't sound like it's only about aux packages (which it sounded to me like that before).

@ffaf1
Copy link
Collaborator

ffaf1 commented Apr 10, 2025

Should this be forward ported to master?

@ulysses4ever
Copy link
Collaborator Author

@ffaf1 I was thinking about it. It's not clear to me that it should. Master has 3.15 everywhere, I think. When 3.16 will be cut, we must make sure that dependencies are handled accordingly. But I'm not sure we want 3.14.2 for version bound on master.

@geekosaur
Copy link
Collaborator

Ah, right, you've just reminded me why it wasn't forward-ported in the first place.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot build with ghc-9.12.2 (Variable not in scope: hasLEUpperBound)
4 participants