Skip to content

remove ambiguity b/t Supervisor/Child/Starter PIDs #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tavisrudd
Copy link
Contributor

  • use SupervisorPid, ChildPid, StarterPid type aliases rather than
    ambiguous ProcessId
  • rename uses of pid as an expr name to childPid or sup

Ideally all internal bits of Supervisor would use phantom types to
make this a type level rather than name based distinction. This is a
first step towards that goal.

- use SupervisorPid, ChildPid, StarterPid type aliases rather than
  ambiguous ProcessId
- rename uses of `pid` as an expr name to `childPid` or `sup`

Ideally all internal bits of Supervisor would use phantom types to
make this a type level rather than name based distinction. This is a
first step towards that goal.
- use SupervisorPid, ChildPid, StarterPid type aliases rather than
  ambiguous ProcessId
- rename uses of `pid` as an expr name to `childPid` or `sup`

Ideally all internal bits of Supervisor would use phantom types to
make this a type level rather than name based distinction. This is a
first step towards that goal.
@tavisrudd
Copy link
Contributor Author

Sorry, in my raising a newborn / sleep-deprived state I managed to miss a hunk on the first commit. You'll want to squash these commits together.

@tavisrudd
Copy link
Contributor Author

@hyperthunk have you seen this SupervisorTest case fail ephemerally before? I can't replicate it locally.
https://travis-ci.org/haskell-distributed/distributed-process-platform/jobs/24319462#L1111

ExitShutdown Is Considered Normal (Closure): [Failed]

unexpected child ref: ("transient-worker",Just (ChildRunning pid://127.0.0.1:8080:0:141,ChildSpec {childKey = "transient-worker", childType = Worker, childRestart = Transient, childStop = TerminateImmediately, childStart = RunClosure (Closure (Static (StaticApply (StaticLabel "$const") (StaticLabel "Main.blockIndefinitely"))) ""), childRegName = Nothing}))

@hyperthunk
Copy link
Member

@tavisrudd - I haven't seen that one for a while now, but IIRC I did see it previously. I'll have to dig into it.

@hyperthunk hyperthunk merged commit 9d9276c into haskell-distributed:development May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants