improve handling of unrecoverable errors caught in doRestartChild #88
Conversation
The `Left` branch of doStartChild is unrecoverable. It currently drops the affected child without logging.
See discussion on PR haskell-distributed#87.
tavisrudd
changed the title
| . (bumpStats Active chType decrement) | ||
| . (bumpStats Specified chType decrement) | ||
| $ removeChild spec st | ||
| ) | ||
| else die $ "Unrecoverable error in child " ++ (childKey spec) |
There was a problem hiding this comment.
I'm not sure if die is the right way to crap out here. It might be better to refactor the type of this function so that we can stop with a non-normal exit reason. The question is, do we want to propagate any information to the children at this point? If there is a shutdown strategy in place (order, timeouts, etc) do we want to observe the configured policies when terminating the other children? Just crashing the supervisor process is a pretty extreme step to take.
Let me poke around in the code and see how things fit (since I've forgotten!) and we can discuss this point a bit more.
There was a problem hiding this comment.
Right. What I intended was shutdown the other children and exit abnormally. I was forgetting that die is too brutal for that.
See discussion on 6656a92.
The
Leftbranch of doStartChild is unrecoverable. It currently dropsthe affected child without logging.
See discussion in PR #87.