Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Use https for all links #196

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Use https for all links #196

merged 1 commit into from
Oct 18, 2020

Conversation

dns2utf8
Copy link
Contributor

@dns2utf8 dns2utf8 commented Oct 4, 2020

Hi all

This is a followup to gtk-rs/gtk#1054

Cheers,
Stefan

README.md Outdated

- [Online documentation](http://gtk-rs.org/docs/)
- [Online documentation](https://gtk-rs.org/docs/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid link.

@dns2utf8
Copy link
Contributor Author

Fixed

@dns2utf8
Copy link
Contributor Author

I am not sure what happend to src/attr_list.rs since I changed one character not the complete file...

@GuillaumeGomez
Copy link
Member

src/attr_list.rs was removed so please don't bring it back from the dead haha.

@dns2utf8
Copy link
Contributor Author

Ahh, okay 😄 removing it fixed the weird diff

@GuillaumeGomez
Copy link
Member

Sorry, I was completely wrong, the file is still there apparently... I wonder what happened in the previous diff then... So, please only change the URL in the header of the file I guess XD (and sorry for the misunderstanding...). Also, if you didn't do it, I suggest you to rebase on master, maybe the weird things come from the master branch?

Hi all

This is a followup to gtk-rs/gtk#1054

Cheers,
Stefan
@dns2utf8
Copy link
Contributor Author

I pulled this master and copied the file manually. Now it works as expected and the GH diff looks okay too.
Not sure why it went so wrong the last time 🤷 😄

@GuillaumeGomez
Copy link
Member

Dark magic. 😆

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit a9fdf54 into gtk-rs:master Oct 18, 2020
@dns2utf8 dns2utf8 deleted the https branch October 20, 2020 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants