This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Replace unwrap calls with expect in tests #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You didn't update the ones you initially complained about :) See src/subclass/object.rs tests. |
|
That was merged after. I'll update the PR shortly. |
|
The tests were already there before that PR :) |
|
Then it's cat invasion! 🏃♂️ |
GuillaumeGomez
force-pushed
the
expect-powa
branch
from
a6ac205 to
8a2e8d6
Compare
|
I think I did all of the ones you added? |
|
Let's merge then. Compared to an |
|
It helps a bit from my point of view so I do care. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592.
cc @sdroege @EPashkin