Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Fix building with upper gtk versions #85

Merged
merged 1 commit into from
Apr 23, 2016
Merged

Conversation

EPashkin
Copy link
Member

IMHO gtk_3_18 feature better changed to gtk_3_16 for consistency
Also defaults commented as example

@GuillaumeGomez
Copy link
Member

Agreed. Thanks @EPashkin.

cc @gkoz

@EPashkin
Copy link
Member Author

EPashkin commented Apr 22, 2016

Not sure how to change to v3_16: just lower feature or also lower installed version in travis.

@GuillaumeGomez
Copy link
Member

Just the feature should be enough.

@EPashkin
Copy link
Member Author

Lowered feature

@EPashkin
Copy link
Member Author

Any 3_18 still won't builds due Gesture

@EPashkin
Copy link
Member Author

Repush to restart builds

@GuillaumeGomez
Copy link
Member

@EPashkin: If you want to restart builds, just ask to me or to @gkoz.

@gkoz
Copy link
Member

gkoz commented Apr 22, 2016

Just removing gtk_3_18 will break appveyor for all other repos.

@EPashkin
Copy link
Member Author

Add it again as gtk_3_18 = ["gtk_3_16"] ?

@EPashkin
Copy link
Member Author

We can also add gtk_latest = ["gtk_3_16"] and update all other repos to it.

@gkoz
Copy link
Member

gkoz commented Apr 22, 2016

latest isn't too good when looked at from the point of view of the CI build matrix.
I think I'd prefer gtk_3_18 = ["gtk_3_16"] but with a comment pointing out that it's used by CI tools. But then there remains little reason to have gtk_3_16. You just can't win it seems.

@EPashkin
Copy link
Member Author

EPashkin commented Apr 22, 2016

IMHO main reason for "gtk_3_16" is example of right way of adding versions.

@@ -19,8 +19,10 @@ git = "https://github.com/gtk-rs/gdk"
git = "https://github.com/gtk-rs/gtk"

[features]
#default = ["gtk_3_18"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we saying by including this line? It could be interpreted in unpredictable ways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its example for setting upper version by default

@gkoz
Copy link
Member

gkoz commented Apr 23, 2016

Anyway, bikeshedding this is too boring. Thanks!

@gkoz gkoz merged commit c7ceae5 into gtk-rs:pending Apr 23, 2016
@EPashkin EPashkin deleted the gtk_version branch April 23, 2016 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants