-
-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
Not sure how to change to v3_16: just lower feature or also lower installed version in travis. |
Just the feature should be enough. |
Lowered feature |
Any 3_18 still won't builds due |
Repush to restart builds |
Just removing |
Add it again as |
We can also add |
|
IMHO main reason for "gtk_3_16" is example of right way of adding versions. |
@@ -19,8 +19,10 @@ git = "https://github.com/gtk-rs/gdk" | |||
git = "https://github.com/gtk-rs/gtk" | |||
|
|||
[features] | |||
#default = ["gtk_3_18"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are we saying by including this line? It could be interpreted in unpredictable ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its example for setting upper version by default
Anyway, bikeshedding this is too boring. Thanks! |
IMHO
gtk_3_18
feature better changed togtk_3_16
for consistencyAlso
defaults
commented as example