Skip to content

bazel: Remove http_file trick for neverlink #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 30, 2018

The trick wasn't necessary, as any java_library can mark itself as
neverlink which applies to its dependencies.

The trick wasn't necessary, as any java_library can mark itself as
neverlink which applies to its dependencies.
@dapengzhang0
Copy link
Member

cc @davido

Copy link
Contributor

@davido davido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @davido !

@ejona86 ejona86 merged commit 989bc87 into grpc:master Jul 30, 2018
@ejona86 ejona86 deleted the bazel-rm-http-file branch July 30, 2018 20:24
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants