Skip to content

xds: Allow Gradle to use more memory when building interop - GCE (v1.48.x backport) #10405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

xds: Allow Gradle to use more memory when building interop - GCE (v1.48.x backport) #10405

merged 1 commit into from
Jul 24, 2023

Conversation

sergiitk
Copy link
Member

Backport of #9354 to v1.48.x.

Same as #9347, but for GCE framework too (xds and xds_v3 jobs).

Should fix "Expiring Daemon because JVM heap space is exhausted".

PR #9269 probably pushed the build
over the edge, but there's been evidence via flakes for a good while
that we've been reaching the limit.

b/238334438

@sergiitk
xds: Allow Gradle to use more memory when building interop - GCE (grp…
38644df 
…c#9354)

Same as grpc#9347, but for GCE framework too (xds and xds_v3 jobs).

Should fix "Expiring Daemon because JVM heap space is exhausted".

PR grpc#9269 probably pushed the build
over the edge, but there's been evidence via flakes for a good while
that we've been reaching the limit.

b/238334438
@sergiitk sergiitk requested a review from ejona86 July 22, 2023 00:18
@sergiitk sergiitk enabled auto-merge (squash) July 22, 2023 00:18
ejona86
ejona86 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it.options.fork = true as done in #10299 significantly helped the OOM. This is fine, but if we still see trouble, we should add the fork to older branches.

@sergiitk sergiitk merged commit ab33d0c into grpc:v1.48.x Jul 24, 2023
@sergiitk sergiitk deleted the backport-1.48-xds-interop-gradle-memory branch July 24, 2023 19:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiitk @ejona86