ESM-v2: Add SNS as a failure destination for Kinesis and DynamoDB

[lizard-boy]

Motivation

This PR enables and tests SNS as a failure destination DLQ in Localstack ESM v2 for Kinesis and DynamoDBStreams events, where AWS event source mapping supports adding either an SQS queue or SNS topic as a failure destination.

See snippet AWS::Lambda::EventSourceMapping OnFailure docs:

Changes

• Allows for an SNS topic ARN to be selected as an OnFailure.Destination for StreamPoller type pollers (Kinesis & DynamoDBStreams)

Testing

To ensure the correct payload was being sent to the SNS DLQ, the tests create an SQS object and subscribe it to the SNS topic, with the resulting object being snapshotted and used for parity testing:

• DynamoDB Streams:

tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_dynamodbstreams.py::TestDynamoDBEventSourceMapping::test_dynamodb_event_source_mapping_with_sns_on_failure_destination_confi

• Kinesis:

tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_kinesis.py::TestKinesisSource::test_kinesis_event_source_mapping_with_sns_on_failure_destination_config

[greptile-apps]

PR Summary

This PR adds support for using SNS as a failure destination (DLQ) for Kinesis and DynamoDB Streams event source mappings in Lambda functions, aligning LocalStack's functionality with AWS.

• Modified StreamPoller class to handle SNS topics as failure destinations
• Added 'sns:*' to allowed actions in s3_lambda_permission policy for Lambda testing
• Implemented new test cases for DynamoDB and Kinesis event source mappings with SNS failure destinations
• Updated test snapshots and validation files to include new SNS-related test scenarios
• Enhanced error handling and verification processes in the new test cases

_{8 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

style: Consider using a constant for sleep time instead of a conditional