-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Clarify 'Values of Correct Type' rule relates to literals #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7fe1b5a
Clarify 'Values of Correct Type' rule does not apply to variables.
benjie 7d86799
Clarify nested variable usages in Values of Correct Type
benjie d5866f7
Merge branch 'main' into values-of-correct-type-variables
benjie 560a9cb
Change from referenced variable's type to suitable usage in its position
benjie ee80b36
Further editing
benjie daf28a2
The assumption is only valid locally.
benjie 14e7c91
Merge branch 'main' into values-of-correct-type-variables
benjie 7d9baa9
coercibility -> coercible to pass spell check
benjie 0c25faa
Merge branch 'main' into values-of-correct-type-variables
benjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.