Skip to content

Make juniper_hyper functions return Response<Body> where applicable #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2021

Conversation

samuela
Copy link
Contributor

@samuela samuela commented Mar 1, 2021

Fix #881.

Changes juniper_hyper to return Response<Body> instead of Result<Response<Body>, hyper::Error> for:

  • graphql
  • graphql_sync
  • graphiql
  • playground

Feel free to let me know if I'm missing any others!

@samuela
Copy link
Contributor Author

samuela commented Mar 5, 2021

Test failures don't seem to be related.

@LegNeato
Copy link
Member

LegNeato commented Apr 2, 2021

Thank you! 🍻

@LegNeato LegNeato merged commit 7a76be7 into graphql-rust:master Apr 2, 2021
@samuela samuela deleted the samuela/fix-881 branch April 2, 2021 04:16
@LegNeato
Copy link
Member

LegNeato commented Apr 4, 2021

This is now on crates.io. Thank you again!

@samuela
Copy link
Contributor Author

samuela commented Apr 4, 2021

Sweet, thanks @LegNeato!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Response instead of Result<Response, hyper::Error> from juniper_hyper::graphql (and others)
2 participants