Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
juniper_warp
will kill the websocket at the firststop
call or if a deserialization error is encountered. This means that any running operation (such as a subscription) that is stopped will require the client to reconnect and set up its subscriptions again.This fix does two things:
connection_init
commandconnection_terminate
commandBoth are modeled after the Apollo implementation https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md