Skip to content

Fix overflow for recursive types #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix overflow for recursive types #361

merged 1 commit into from
Apr 13, 2021

Conversation

noverby
Copy link
Contributor

@noverby noverby commented Apr 9, 2021

Fixes #302

tomhoule
tomhoule approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR

@noverby
Copy link
Contributor Author

noverby commented Apr 11, 2021

@tomhoule nice! When do you expect a new release with this PR?

@tomhoule
Copy link
Member

@noverby I can't say — some manual QA and updating of the changelog needs to happen before the next release, and I personally don't have the time at the moment. Contributions in that regard are very welcome, though.

@tomhoule tomhoule merged commit 472aad5 into graphql-rust:master Apr 13, 2021
@Ten0 Ten0 mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thread 'rustc' has overflowed its stack
2 participants
@noverby @tomhoule