Skip to content

feat: added json path features to GraphQLResponse #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

bsara
Copy link
Contributor

@bsara bsara commented Oct 25, 2023

Adds JsonPath features to GraphQLResponse. See #136 for details.

I wanted to ensure that this remained backward compatible, so I created new methods that would ensure there would be no breaking changes: getAt(String, Class), getAt(String), and getListAt(String, Class).

I do believe that the implementations of get and getList could be updated to support JsonPath without breaking backward compatibility. However, I wanted to err on the side of caution and I don't know what the preference of the maintainers would be either. I'm happy to make any needed changes as well.

@bsara bsara force-pushed the response-json-path branch 2 times, most recently from 788d023 to 48f744f Compare October 26, 2023 22:53
@bsara bsara changed the title feat: added json path features to GraphQLResponse; resolves #137 feat: added json path features to GraphQLResponse Oct 26, 2023
@bsara bsara force-pushed the response-json-path branch from 48f744f to 21b1741 Compare October 26, 2023 22:59
@oliemansm oliemansm merged commit 5184822 into graphql-java-kickstart:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants