Measure effect of tokio contention in event processing #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to do this.
ghost
added
the
Jannis
reviewed
May 10, 2019
| @@ -275,7 +275,7 @@ impl RuntimeHost { | |||
| }; | |||
|
|
|||
| result_sender | |||
| .send(result) | |||
| .send((result, future::ok(Instant::now()))) | |||
There was a problem hiding this comment.
Does this need to be a future?
There was a problem hiding this comment.
Having this be IntoFuture lets us keep the rest of the code untouched, so the options were either Result<Instant, Error> (being always Ok) or futures::Finished<Instant, Error> which I went with. This log is a temporary thing anyhow, once we improve things and get less contention warnings, this will be overkill.
There was a problem hiding this comment.
Makes sense. The reason I'm asking about the future is that I wonder if the wait later could add undesired extra time to the measurement.
There was a problem hiding this comment.
Yhea .wait() sounds like it's waiting but that will actually be instant. I improved the comment.
Jannis
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since contention warnings are showing up we could use a more exact measure of how contention affects event processing speed. Relevant to #856 and #905.