Skip to content

Measure effect of tokio contention in event processing #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2019

Conversation

leoyvens
Copy link
Collaborator

@leoyvens leoyvens commented May 10, 2019

Since contention warnings are showing up we could use a more exact measure of how contention affects event processing speed. Relevant to #856 and #905.

@leoyvens leoyvens requested a review from a team May 10, 2019 15:25
@leoyvens leoyvens self-assigned this May 10, 2019
@ghost ghost added the pending review label May 10, 2019
@@ -275,7 +275,7 @@ impl RuntimeHost {
};

result_sender
.send(result)
.send((result, future::ok(Instant::now())))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a future?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this be IntoFuture lets us keep the rest of the code untouched, so the options were either Result<Instant, Error> (being always Ok) or futures::Finished<Instant, Error> which I went with. This log is a temporary thing anyhow, once we improve things and get less contention warnings, this will be overkill.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The reason I'm asking about the future is that I wonder if the wait later could add undesired extra time to the measurement.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yhea .wait() sounds like it's waiting but that will actually be instant. I improved the comment.

@leoyvens leoyvens merged commit 32de498 into master May 10, 2019
@leoyvens leoyvens deleted the leo/move-event-done-log branch May 10, 2019 20:11
@ghost ghost removed the pending review label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants