Monitor contention in tokio threadpool #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
reviewed
May 8, 2019
| @@ -64,7 +63,6 @@ lazy_static! { | |||
| git_testament!(TESTAMENT); | |||
|
|
|||
| fn main() { | |||
| println!("REORG_THRESHOLD = {:#?}", *REORG_THRESHOLD); | |||
ghost
reviewed
May 8, 2019
node/src/main.rs
Outdated
| ); | ||
| let contention_logger = logger.clone(); | ||
| std::thread::spawn(move || loop { | ||
| std::thread::sleep(Duration::from_secs(10)); |
There was a problem hiding this comment.
My gut is telling me that 10 seconds is too sparse, contention could come and go during that window.
This seems cheap enough to run every 10ms - 100ms. Is that the case?
There was a problem hiding this comment.
Agreed, I'll lower to 100ms.
| ping_send.clone().send(pong_send).wait().unwrap(); | ||
| let mut timeout = Duration::from_millis(1); | ||
| while pong_receive.recv_timeout(timeout).is_err() { | ||
| warn!(contention_logger, "Possible contention in tokio threadpool"; |
There was a problem hiding this comment.
If add a LogCode here, that would help in making a Grafana panel + alert for this
There was a problem hiding this comment.
I'll add a code, but we should probably alert on any warn level log.
ghost
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple mechanism that periodically checks the threadpool responsiveness. Part of the investigation for #856.