graph: IPFS_MAX_ATTEMPTS ani-smap mechanism env var #5998
Merged
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encalypto
approved these changes
May 9, 2025
|
Is this really just for deterministic errors? I don't see anything that is classifying the errors as deterministic and only hitting max for those. |
lutter
requested changes
May 9, 2025
docs/environment-variables.md
Outdated
| @@ -87,6 +87,9 @@ those. | |||
| - `GRAPH_MAX_IPFS_CACHE_SIZE`: maximum number of files cached (defaults to 50). | |||
| - `GRAPH_MAX_IPFS_CACHE_FILE_SIZE`: maximum size of each cached file (in bytes, defaults to 1MiB). | |||
| - `GRAPH_IPFS_REQUEST_LIMIT`: Limits the number of requests per second to IPFS for file data sources. | |||
| - `GRAPH_IPFS_MAX_ATTEMPTS`: Safety mechanism to prevent infinite spamming | |||
| of IPFS servers in the event of logical or unhandled deterministic | |||
| error (default: 100 000) | |||
There was a problem hiding this comment.
The description should explain what this variable does, not why you would want to use it. Also the next line seems to belong to GRAPH_IPFS_REQUEST_LIMIT
There was a problem hiding this comment.
thanks, will fix that and add a better description
lutter
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the hardcoded DEFAULT_MAX_ATTEMPTS to a configurable env var GRAPH_NODE_IPFS_MAX_ATTEMPTS to avoid spamming the IPFS on deterministic errors