chore: simplify DateLib types #2735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifying the DateLib types to allow using the Ethipic date lib. This is a second approach for #2655.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Giampaolo Bellavite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
date-fnslibrary allows initializing dates using numbers or strings (example). However, this behavior can cause issues when overriding theDateLib, such as when working with the Ethiopic calendar.To address this, I replaced the
DateLibdefinitions with more explicit types, as this feature is not used by DayPicker. This change will allow us to continue working on the Ethiopic DateLib.(Note: This is a second attempt to address #2655, which was previously reverted to resolve #2723. Since a test for that bug has been added, this change should now be safe. The bug in the first PR was related to the way I was passing the options to some of them)