fix: fix left/right icon alignment #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecRust
force-pushed
the
fix-right-arrow
branch
from
9e578c9 to
0ab060f
Compare
|
Nice find @AlecRust ! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
In Chevron.tsx different SVG code is used for each icon direction needed (rather than e.g. rotating the same icon).
The "up" vs "down" icons seem to use almost identical code, with the only changes being the direction it's pointing in.
However the "right" arrow compared with the "left" arrow has more
pointscode, and it's also positioned slightly lower.This PR updates the
pointscode of the right arrow to better match the left arrow and fix the misalignment.I've zoomed in to make this comparison more obvious, but I've noticed the slight misalignment of the left/right arrows since using this library at the normal zoom level.
Before:
After:
Type of Change