Skip to content

fix: render selected days with selected modifier when disabled #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions examples/DisabledSelectedDate.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import React from "react";

import { gridcell } from "@/test/elements";
import { render } from "@/test/render";

import { DisabledSelectedDate } from "./DisabledSelectedDate";

test("selected days should render with 'selected' modifier when disabled", () => {
render(<DisabledSelectedDate />);

const dayBeforeRangeStart = new Date(2025, 2, 7);
expect(gridcell(dayBeforeRangeStart, true)).not.toHaveClass("rdp-selected");
expect(gridcell(dayBeforeRangeStart, true)).not.toHaveStyle(
"background-color: red"
);
const rangeStart = new Date(2025, 2, 8);
expect(gridcell(rangeStart, true)).toHaveClass("rdp-selected");
expect(gridcell(rangeStart, true)).toHaveStyle("background-color: red");

rangeStart.setDate(rangeStart.getDate() + 1);
expect(gridcell(rangeStart, true)).toHaveClass("rdp-selected");
expect(gridcell(rangeStart, true)).toHaveStyle("background-color: red");

rangeStart.setDate(rangeStart.getDate() + 1);
expect(gridcell(rangeStart, true)).toHaveClass("rdp-selected");
expect(gridcell(rangeStart, true)).toHaveStyle("background-color: red");

rangeStart.setDate(rangeStart.getDate() + 1);
expect(gridcell(rangeStart, true)).toHaveClass("rdp-selected");
expect(gridcell(rangeStart, true)).toHaveStyle("background-color: red");

rangeStart.setDate(rangeStart.getDate() + 1);
expect(gridcell(rangeStart, true)).not.toHaveClass("rdp-selected");
expect(gridcell(dayBeforeRangeStart, true)).not.toHaveStyle(
"background-color: red"
);
});
31 changes: 31 additions & 0 deletions examples/DisabledSelectedDate.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import React from "react";

import { DayPicker } from "react-day-picker";

const today = new Date(2025, 2, 8);
const toDate = new Date(today);
toDate.setDate(toDate.getDate() + 3);

/**
* Test case for issue #2699
*
* @see https://github.com/gpbl/react-day-picker/issues/2699
*/
export function DisabledSelectedDate() {
return (
<DayPicker
mode="range"
disabled
today={today}
modifiersStyles={{
selected: {
backgroundColor: "red"
}
}}
selected={{
from: today,
to: toDate
}}
/>
);
}
4 changes: 2 additions & 2 deletions examples/TestCase2047.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ beforeEach(async () => {
render(<TestCase2047 />);
});

test("disabled date is not selected", () => {
expect(gridcell(new Date(2024, 5, 10), true)).not.toHaveAttribute(
test("disabled date renders with selected modifier", () => {
expect(gridcell(new Date(2024, 5, 10), true)).toHaveAttribute(
"aria-selected"
);
});
Expand Down
1 change: 1 addition & 0 deletions examples/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export * from "./CustomWeek";
export * from "./DefaultMonth";
export * from "./Dialog";
export * from "./Disabled";
export * from "./DisabledSelectedDate";
export * from "./DisableNavigation";
export * from "./Dropdown";
export * from "./DropdownMonths";
Expand Down
3 changes: 1 addition & 2 deletions src/DayPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,7 @@ export function DayPicker(props: DayPickerProps) {
Boolean(focused?.isEqualTo(day));

modifiers[SelectionState.selected] =
!modifiers.disabled &&
(isSelected?.(date) || modifiers.selected);
isSelected?.(date) || modifiers.selected;

if (isDateRange(selectedValue)) {
// add range modifiers
Expand Down