Skip to content

Set the tidy-html5 OSS-Fuzz contact info to @balthisar #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

stefanbucur
Copy link
Contributor

@DavidKorczynski
Copy link
Collaborator

CI fails:

[54/56] Building C object CMakeFiles/tidy-static.dir/src/tidylib.c.o
[55/56] Linking C static library libtidy.a
[55/56] Linking C static library libtidy.a
[55/56] Building C object CMakeFiles/tidy.dir/console/tidy.c.o
[56/56] Linking C executable tidy
[56/56] Linking C executable tidy
+ for fuzzer in tidy_config_fuzzer tidy_fuzzer
+ clang -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -c -I/src/tidy-html5/include /src/tidy_config_fuzzer.c -o tidy_config_fuzzer.o
+ clang++ -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -stdlib=libc++ -std=c++11 tidy_config_fuzzer.o -o /out/tidy_config_fuzzer -fsanitize=fuzzer libtidys.a
clang-12: error: no such file or directory: 'libtidys.a'

Looks like it should be libtidy.a rather than libtidys.a during linking?

@balthisar
Copy link

On non-Windows systems we properly name the static library libtidy.a now, instead of libtidy.s; this is a recent change.

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't think we need to block this PR on the CI breakage. It's unrelated.

@jonathanmetzman jonathanmetzman merged commit 4d96eed into google:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants