-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Safe FFI exercise: dirent
layout is different on Mac OS
#570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The man page for my system says:
|
schultetwin1
added a commit
to schultetwin1/comprehensive-rust
that referenced
this issue
Apr 20, 2023
Use the macOS definition of dirent. Fixes google#570
Thanks @ericye16! @schultetwin1 was able to open a PR based on the man page above, so we should have this fixed now. |
mgeisler
added a commit
that referenced
this issue
Apr 21, 2023
* Fix safe FFI exercise on macOS Use the macOS definition of dirent. Fixes #570 --------- Co-authored-by: Martin Geisler <[email protected]>
Closed
mgeisler
added a commit
that referenced
this issue
Jun 19, 2023
This would have helped us catch #570.
mgeisler
added a commit
that referenced
this issue
Jun 20, 2023
This would have helped us catch #570.
mgeisler
added a commit
that referenced
this issue
Jun 22, 2023
* Run builds on both Mac OS and Linux This would have helped us catch #570. * Fix MacOS CI (#848) * Revert unnecessary changes The changes might be good, but I want to keep this PR small and focused. If we end up with the extra `cfg` statements, we should include a comment to let students know what they do: we’re targeting people new to Rust, so we need to be careful with explanations. --------- Co-authored-by: Dominik Maier <[email protected]>
NoahDragon
pushed a commit
to wnghl/comprehensive-rust
that referenced
this issue
Jul 19, 2023
* Fix safe FFI exercise on macOS Use the macOS definition of dirent. Fixes google#570 --------- Co-authored-by: Martin Geisler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The safe FFI wrapper exercise uses the wrong layout on Mac OS.
The text was updated successfully, but these errors were encountered: