cmd/link: disable TestPIESize if CGO isn't enabled #43911
Conversation
google-cla
bot
added
the
cla: yes
|
This PR (HEAD: 52c5346) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/286632 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=bc366df7 Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Go Bot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Ian Lance Taylor: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Matthew Dempsky: Patch Set 1: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Cherry Zhang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Cherry Zhang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Nehal J Wani: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Cherry Zhang: Patch Set 1: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
nehaljwani
force-pushed
the
disable-TestPIESize-no-cgo
branch
from
52c5346 to
eb0e54f
Compare
With CGO disabled, the test throws the following error:
elf_test.go:291: # command-line-arguments
loadinternal: cannot find runtime/cgo
nehaljwani
force-pushed
the
disable-TestPIESize-no-cgo
branch
from
eb0e54f to
f8fe9af
Compare
|
This PR (HEAD: f8fe9af) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/286632 to see it. Tip: You can toggle comments from me using the |
|
Message from Nehal J Wani: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=2d25961c Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
|
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/286632. |
With CGO disabled, the test throws the following error:
elf_test.go:291: # command-line-arguments
loadinternal: cannot find runtime/cgo
Change-Id: Iaeb183562ab637c714240b49e73078bdb791b35b
GitHub-Last-Rev: f8fe9af
GitHub-Pull-Request: #43911
Reviewed-on: https://go-review.googlesource.com/c/go/+/286632
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Cherry Zhang <[email protected]>
Trust: Matthew Dempsky <[email protected]>
|
This PR is being closed because golang.org/cl/286632 has been merged. |
With CGO disabled, the test throws the following error:
elf_test.go:291: # command-line-arguments
loadinternal: cannot find runtime/cgo