fmt: explain how Formatter interface affects verbs and flags #39860
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 7d7eac8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
|
Message from Rob Pike: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
This PR (HEAD: 7d23fbd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
|
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
bboreham
force-pushed
the
formatter-note
branch
from
7d23fbd to
416bbd1
Compare
|
This PR (HEAD: 416bbd1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 7b16237) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
|
Message from Bryan Boreham: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
Message from Rob Pike: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
Message from Sam Mortimer: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
bboreham
force-pushed
the
formatter-note
branch
from
7b16237 to
431d7a7
Compare
|
This PR (HEAD: 431d7a7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
Explain the arguments to Format(), and also make clear that the meaning of flags and verbs is entirely devolved to an operand that implements Formatter.
bboreham
force-pushed
the
formatter-note
branch
from
431d7a7 to
3fa21a2
Compare
|
This PR (HEAD: 3fa21a2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
|
Message from Bryan Boreham: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
Message from Rob Pike: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
This PR (HEAD: 6571b49) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/240000 to see it. Tip: You can toggle comments from me using the |
|
Message from Rob Pike: Patch Set 7: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
Message from Rob Pike: Patch Set 7: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
Formatter is mentioned further down, but it's helpful to add it amongst the verbs and flags. Background: I spent a while puzzling how "%+v" prints a stack trace for github.com/pkg/errors when this isn't documented under 'flags'. Change-Id: Ic70145902a36780147dedca568b3cf482974fc38 GitHub-Last-Rev: 6571b49 GitHub-Pull-Request: #39860 Reviewed-on: https://go-review.googlesource.com/c/go/+/240000 Reviewed-by: Rob Pike <[email protected]> Trust: Rob Pike <[email protected]> Trust: Ian Lance Taylor <[email protected]>
|
Message from Ian Lance Taylor: Patch Set 7: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/240000. |
|
This PR is being closed because golang.org/cl/240000 has been merged. |
Formatter is mentioned further down, but it's helpful
to add it amongst the verbs and flags.
Background: I spent a while puzzling how "%+v" prints
a stack trace for github.com/pkg/errors when this isn't
documented under 'flags'.