cmd/8l: fix "non-pc-relative relocation address is too big"

[gopherbot]

by liu.kz.2010:

--- a/src/cmd/ld/ldpe.c    Sat Apr 12 14:00:53 2014 +0800
+++ b/src/cmd/ld/ldpe.c Sat Apr 12 15:55:33 2014 +0800
@@ -297,7 +297,7 @@
                case IMAGE_REL_I386_DIR32:
                    rp->type = D_ADDR;
                    // load addend from image
-                   rp->add = le32(rsect->base+rp->off);
+                   rp->add = (int32)le32(rsect->base+rp->off);
                    break;
                case IMAGE_REL_AMD64_ADDR64: // R_X86_64_64
                    rp->siz = 8;

[ianlancetaylor]

Comment 1:

Do you have a test case that shows the problem?

Labels changed: added repo-main, release-go1.3.

[gopherbot]

Comment 2 by liu.kz.2010:

// test.go 
package main
/*
#cgo windows,386 LDFLAGS: libfoo.a -lstdc++
int foo1();
*/
import "C"
import "fmt"
func main() {
    C.foo1()
    fmt.Println()
}
/*
Windows XP(SP3)
gcc version 4.8.1 (tdm-2) 
output: 
main(.text): non-pc-relative relocation address is too big: 0x1004e3a98
main(.text): non-pc-relative relocation address is too big: 0x1004e3a98
main(.text): undefined: pthread_key_create
main(.text): undefined: pthread_once
main(.text): undefined: pthread_setspecific
main(.text): undefined: pthread_setspecific
main(.text): undefined: pthread_getspecific
main(.text): undefined: pthread_setspecific
main(.text): undefined: pthread_setspecific
main(.text): undefined: pthread_getspecific
main(.text): undefined: pthread_getspecific
main(.text): undefined: pthread_getspecific
main(.text): undefined: pthread_getspecific
main(.text): undefined: pthread_getspecific
*/

Attachments:

1. libfoo.a (117492 bytes)

[rsc]

Comment 3:

Labels changed: added release-go1.3maybe, removed release-go1.3.

Status changed to Accepted.

[gopherbot]

Comment 4:

CL https://golang.org/cl/88000045 mentions this issue.

[minux]

Comment 5:

This issue was closed by revision d0d425a.

Status changed to Fixed.