cmd/compile: failure in k8s after golang tools module update

[Rajalakshmi-Girish]

Go version

go version devel go1.24-de0aafa3c7 Wed Sep 4 20:42:05 2024 +0000 linux/amd64

Output of go env in your module/workspace:

[root@raji-x86-workspace1 src]# go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.24-004686b6e5 Wed Sep 4 20:37:00 2024 +0000'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/root/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD='/root/go_src/go/src/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1003699293=/tmp/go-build -gno-record-gcc-switches'
[root@raji-x86-workspace1 src]#

What did you do?

Building of binaries in kubernetes repo
Running of k8s UT

What did you see happen?

# [k8s.io/kubernetes/test/e2e_node]
test/e2e_node/util_sriov.go:45:19: non-constant format string in call to k8s.io/kubernetes/test/e2e/framework.Failf
test/e2e_node/util_sriov.go:47:20: non-constant format string in call to k8s.io/kubernetes/test/e2e/framework/skipper.Skipf
test/e2e_node/system_node_critical_test.go:93:21: non-constant format string in call to k8s.io/kubernetes/test/e2e/framework.Logf
test/e2e_node/system_node_critical_test.go:94:24: non-constant format string in call to fmt.Errorf
test/e2e_node/system_node_critical_test.go:103:22: non-constant format string in call to k8s.io/kubernetes/test/e2e/framework.Logf

Steps to Reproduce:

1. Setup go version devel version de0aafa3c7f669df0a93dd62cc336ebda52815f2
2. git clone https://github.com/kubernetes/kubernetes
3. cd kubernetes
4. run KUBE_BUILD_PLATFORMS=linux/amd64 make cross

What did you expect to see?

The binary should be built successfully.

[gabyhelp]

Related Issues and Documentation

• cmd/compile: internal compiler error: lost track of variable in liveness while building kubernetes #19632 (closed)
• cmd/cgo: regression in Kubernetes build on ppc64le due to commit 90df377 #28772 (closed)
• runtime/debug: internal compiler error when building Kubernetes introduced in commit fdecaa8 #23179 (closed)
• cmd/go/internal/doc: exit status printed #44950
• cmd/compile: "undefined: uuid..autotmp_1" while building kubernetes #30498 (closed)
• cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes #19425 (closed)
• cmd/compile: internal compiler error while building targets for kubernetes with master go #44370 (closed)
• cmd/link: relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy' #58425 (closed)
• cmd/go: difficulty resolving 'error loading module requirements' with kubernetes #32864 (closed)
• cmd/compile: invalid offset for DS form load/store 00376 while building kubernetes binaries on ppc64le platform #42181 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[mvdan]

Those are vet errors and most likely correct. Have you tried fixing them?

[Rajalakshmi-Girish]

@mvdan We have many tests in k8s that are to be fixed.
This seems mundane to do manually. Can you please suggest if there is a way to fix them in one go?
@seankhliao