Skip to content

x/tools/cmd/guru: tag and delete #65880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
adonovan opened this issue Feb 22, 2024 · 8 comments
Closed
3 tasks done

x/tools/cmd/guru: tag and delete #65880

adonovan opened this issue Feb 22, 2024 · 8 comments
Assignees
@adonovan
Labels
FrozenDueToAge Proposal Proposal-Accepted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

adonovan commented Feb 22, 2024 •
edited by findleyr
Loading

cmd/guru was Go's LSP server before LSP was invented. But now we have gopls, which is better in every* way. (guru used to have some interesting features based on pointer analysis, but no longer: the pointer analysis was deleted as it was inherently fragile, and didn't scale well.)

To my knowledge, since VS Code Go broke its dependency on guru about a year ago, no-one is really using it any more (nor should they).

I propose to delete cmd/guru:

  • isolate cmd/guru into its own module (https://go.dev/cl/570136)
  • commit a tag cmd/guru/v1.0.0 so that 'go install' will continue to work
  • delete cmd/guru







*nearly every way: I still miss 'freevars'. But I will add it gopls this year.
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 22, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 22, 2024
@adonovan adonovan moved this to Incoming in Proposals Feb 22, 2024
@fzipp
Copy link
Contributor

fzipp commented Feb 22, 2024

I have a project that uses guru, pythia, but I'm happy to archive it. I developed it during the time when guru was known as oracle. However, with gopls integration now being widespread in code editors, I no longer use it.

@seankhliao seankhliao changed the title x/tools/cmd/guru: delete it proposal: x/tools/cmd/guru: delete it Feb 22, 2024
@rsc rsc changed the title proposal: x/tools/cmd/guru: delete it proposal: x/tools/cmd/guru: tag and delete Feb 28, 2024
@rsc
Copy link
Contributor

rsc commented Mar 1, 2024

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

The proposal is to tag a last version of guru as a submodule and then delete it from x/tools. Existing uses should migrate to gopls.

@rsc rsc moved this from Incoming to Likely Accept in Proposals Mar 1, 2024
@nightlyone
Copy link
Contributor

Not to disagree, but useful to mention: guru allowed to identify channel peers. I never found a replacement for that.

@adonovan
Copy link
Member Author

adonovan commented Mar 2, 2024

Not to disagree, but useful to mention: guru allowed to identify channel peers. I never found a replacement for that.

Yeah; that was one of the "interesting features" referred to by my parenthesis.

@rsc rsc moved this from Likely Accept to Accepted in Proposals Mar 8, 2024
@rsc
Copy link
Contributor

rsc commented Mar 8, 2024

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

The proposal is to tag a last version of guru as a submodule and then delete it from x/tools. Existing uses should migrate to gopls.

@rsc rsc changed the title proposal: x/tools/cmd/guru: tag and delete x/tools/cmd/guru: tag and delete Mar 8, 2024
@adonovan adonovan self-assigned this Mar 8, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/570136 mentions this issue: cmd/guru: carve out a separate module

gopherbot pushed a commit to golang/tools that referenced this issue Mar 8, 2024
@adonovan @gopherbot
cmd/guru: carve out a separate module
9e530fc 
This is the first step of deleting guru.

Updates golang/go#65880

Change-Id: Id33729265825f5557a47a5c571b2ae0e2d58336a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/570136
Auto-Submit: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/569882 mentions this issue: cmd/guru: delete it

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/570139 mentions this issue: cmd/guru: remove replace directive

gopherbot pushed a commit to golang/tools that referenced this issue Mar 8, 2024
@adonovan
cmd/guru: remove replace directive
c6563ca 
Updates golang/go#65880

Change-Id: Icb45d94bd2ef0864ab054e76a6aa651b269e2ec5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/570139
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
@suzuki-shunsuke suzuki-shunsuke mentioned this issue Apr 5, 2024
Closed
suzuki-shunsuke added a commit to aquaproj/aqua-registry that referenced this issue Apr 5, 2024
@suzuki-shunsuke
fix(golang/tools/guru): guru was deleted at v0.20.0
9cbd165 
- golang/tools@1f580da
- golang/go#65880

> RIP guru, Go's LSP server before LSP was invented.
@suzuki-shunsuke suzuki-shunsuke mentioned this issue Apr 5, 2024
Merged
suzuki-shunsuke added a commit to aquaproj/aqua-registry that referenced this issue Apr 5, 2024
@suzuki-shunsuke
fix(golang/tools/guru): guru was deleted at v0.20.0 (#21620)
4be7582 
- golang/tools@1f580da
- golang/go#65880

> RIP guru, Go's LSP server before LSP was invented.
This was referenced Jul 4, 2024
Merged
Merged
@panchoh panchoh mentioned this issue Aug 21, 2024
Closed
4 tasks
panchoh added a commit to panchoh/doomemacs that referenced this issue Aug 21, 2024
@panchoh @hlissner
refactor!(go): remove go-guru
292b103 
BREAKING CHANGE: Removes go-guru from the Go module. It has been
deprecated upstream in favor of gopls, the official Go LSP server.

Close: doomemacs#7995
Ref: golang/go/issues/65880
Co-authored-by: Henrik Lissner <[email protected]>
@panchoh panchoh mentioned this issue Aug 21, 2024
Merged
4 tasks
panchoh added a commit to panchoh/doomemacs that referenced this issue Aug 22, 2024
@panchoh @hlissner
refactor!(go): remove go-guru
4bec9f7 
BREAKING CHANGE: Removes go-guru from the Go module. It has been
deprecated upstream in favor of gopls, the official Go LSP server.

Close: doomemacs#7995
Ref: golang/go/issues/65880
Co-authored-by: Henrik Lissner <[email protected]>
hlissner added a commit to doomemacs/doomemacs that referenced this issue Aug 22, 2024
@panchoh @hlissner
refactor!(go): remove go-guru
879c0b0 
BREAKING CHANGE: Removes go-guru from the Go module. It has been
deprecated upstream in favor of gopls, the official Go LSP server.

Close: #7995
Ref: golang/go/issues/65880
Co-authored-by: Henrik Lissner <[email protected]>
libvirgo pushed a commit to libvirgo/doomemacs that referenced this issue Aug 24, 2024
@panchoh @hlissner @libvirgo
refactor!(go): remove go-guru
55c06a8 
BREAKING CHANGE: Removes go-guru from the Go module. It has been
deprecated upstream in favor of gopls, the official Go LSP server.

Close: doomemacs#7995
Ref: golang/go/issues/65880
Co-authored-by: Henrik Lissner <[email protected]>
@skovranek skovranek mentioned this issue Aug 25, 2024
Closed
This was referenced Sep 12, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@alexandear alexandear mentioned this issue Dec 19, 2024
Closed
@golang golang locked and limited conversation to collaborators Mar 8, 2025
@aclements aclements removed this from Proposals Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adonovan adonovan

Labels
FrozenDueToAge Proposal Proposal-Accepted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@rsc @fzipp @nightlyone @adonovan @gopherbot @findleyr