x/pkgsite/internal/fetch: TestExtractReadmes failures

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/fetch" && test == "TestExtractReadmes"

Issue created automatically to collect these failures.

Example (log):

2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetterwork_dir3481770641/001 in 197.766832ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGettermodule_dir1639853321/001/foo in 194.689897ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetternested_package_dir1732045019/001/foo/foolog in 203.872406ms
2023/07/24 13:34:08 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetter_Invalidation1194617697/001 in 5.094307618s
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/basic") => (raw="v1.1.0" cooked="v1.1.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/retractions") => (raw="v1.2.0" cooked="v1.0.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("std") => (raw="v1.21.0" cooked="v1.21.0", <nil>)
--- FAIL: TestExtractReadmes (30.04s)
    --- FAIL: TestExtractReadmes/prefer_README.md (0.02s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/prefer_readme.markdown (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/no_readme (0.01s)
        readme_test.go:121: proxy.Client.Zip(ctx, "emp.ty/module", "v1.0.0"): Client.readBody("emp.ty/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/readme_is_a_directory (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/fetch" && test == "TestExtractReadmes"

2023-07-24 20:30 darwin-amd64-12_0 pkgsite@0bc4b0e9 go@bd3a1f24 x/pkgsite/internal/fetch.TestExtractReadmes (log)

2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetterwork_dir3481770641/001 in 197.766832ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGettermodule_dir1639853321/001/foo in 194.689897ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetternested_package_dir1732045019/001/foo/foolog in 203.872406ms
2023/07/24 13:34:08 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetter_Invalidation1194617697/001 in 5.094307618s
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/basic") => (raw="v1.1.0" cooked="v1.1.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/retractions") => (raw="v1.2.0" cooked="v1.0.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("std") => (raw="v1.21.0" cooked="v1.21.0", <nil>)
--- FAIL: TestExtractReadmes (30.04s)
    --- FAIL: TestExtractReadmes/prefer_README.md (0.02s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/prefer_readme.markdown (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/no_readme (0.01s)
        readme_test.go:121: proxy.Client.Zip(ctx, "emp.ty/module", "v1.0.0"): Client.readBody("emp.ty/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/readme_is_a_directory (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out

— watchflakes

[bcmills]

Looks like this is caused by an unnecessary hard-coded timeout:
https://cs.opensource.google/go/x/pkgsite/+/master:internal/fetch/readme_test.go;l=24-25;drc=64dbd74b14032a5f58252a47fd85377381f3610f

(CC @matloob)

[bcmills]

Fixed in https://go.dev/cl/521837.