proposal: x/sys: move crypto/terminal to sys repository

[binarycrusader]

I would like to propose the addition of a set of functions and supporting data types to support getting / setting terminal window size across platforms.

This would also likely require the addition of something like this to x/sys:

func GetWindowSize(fd int) (winsize *Winsize, err error) {}
func SetWindowSize(fd int, ws *Winsize) (err error) {}
type Winsize struct {
    Row    uint16
    Col    uint16
    Xpixel uint16
    Ypixel uint16
}

On Linux, OS X, etc. this is done via syscalls using ioctl(), etc. On Windows, this is done possibly via GetConsoleScreenBufferInfo and SetConsoleWindowInfo. On Solaris, this is done via libc.ioctl().

Docker (pkg/term/*) and other Go-based projects like to retrieve or set this information, it would be helpful if this was abstracted away for various projects as can be seen in a simple github search of Go source files:

https://github.com/search?utf8=%E2%9C%93&q=%22TIOCGWINSZ%22+extension%3Ago&type=Code&ref=advsearch&l=

I am willing to provide the implementation and tests for Solaris, and Linux, and I can attempt one for Windows.

I have not proposed an addition before to any of the Go packages or tools, so please forgive me if I have not adhered to the correct process ( I'm attempting to follow https://github.com/golang/proposal#readme ).

I don't know if the sys package is the most appropriate place for this or not; I'm just trying to figure out how to avoid the current situation of duplicating terminal information code across various Go projects in the community leading to them not working as expected or being unsupported on some platforms.

[binarycrusader]

Related discussion: https://groups.google.com/forum/#!topic/golang-nuts/c1dOr7eknBA

[bradfitz]

Seems non-controversial to live somewhere.

Note that we already have stuff like http://godoc.org/golang.org/x/crypto/ssh/terminal#GetSize

Maybe that's the right package to complete the work.

[binarycrusader]

@bradfitz Actually, that looks like exactly the functionality I was desiring, with the exception that it lives in an odd place (crypto/ssh, where I never would have thought to look for it).

I wonder if it should be moved to a top-level package instead of being part of crypto/ssh or is it too late to fix the namespacing?

[davecheney]

I've always felt the ssh/terminal package was a storage outlier. I'd
support moving this, and other termios functions into x/sys/termios (or
another less geeky name)

On Wed, 16 Sep 2015 06:21 Shawn notifications@github.com wrote:

Actually, that looks like exactly the functionality I was desiring, with
the exception that it lives in an odd place (crypto/ssh, where I never
would have thought to look for it).

I wonder if it should be moved to a top-level package instead of being
part of crypto/ssh or is it too late to fix the namespacing?

—
Reply to this email directly or view it on GitHub
#12101 (comment).

[binarycrusader]

and other termios functions into x/sys/termios (or another less geeky name)

Well, it's not really "termios" since that's a *NIX concept, so while I hate to engage in bikeshedding, I'd suggest it either belongs in x/sys, x/terminal, or x/term.

I'm happy to do the work if someone wants to suggest the desired direction as I have no particular preference here.

[davecheney]

I'm happy with term, and can contribute Darwin and Linux implementations
from my github.com/pkg/term project.

golang.org/x/sys/term

Sounds fine to me.

On Wed, 16 Sep 2015 09:37 Shawn notifications@github.com wrote:

and other termios functions into x/sys/termios (or another less geeky name)

Well, it's not really "termios" since that's a *NIX concept, so while I
had to engage in bikeshedding, I'd suggest it either belongs in x/sys,
x/terminal, or x/term.

I'm happy to do the work if someone wants to suggest the desired direction
as I have no particular preference here.

—
Reply to this email directly or view it on GitHub
#12101 (comment).

[techtonik]

x/sys/console, because terminal is a limited, slow and messy stuff with its windows control channel mixed into input stream.

I have a Python Windows code for GetWindowSize in case somebody would like to port it, see https://bitbucket.org/techtonik/python-pager/src/2936adb19c9407b8e890949f9e88bf4f0461a524/pager.py?at=default&fileviewer=file-view-default#pager.py-35

[techtonik]

The console interfaces of the future look like those created with https://bitbucket.org/libtcod/libtcod/ so it would be good to plan for that now.