Skip to content

Update godot-cpp to godot-4.2-stable #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link

@dsnopek dsnopek commented Jul 10, 2024

This PR originally updated to the latest in the 4.1 branch, but now that Godot 4.1 is no longer supported, this now updates godot-cpp to the godot-4.2-stable release.

One of the most important changes this includes is PR godotengine/godot-cpp#1313 which fixes #239, which is a crash that's caused when this GDExtension is used in a project with another GDExtension.

Marking as DRAFT for now, because this includes the changes from PR #272 so that CI will pass

Original description (before 2025-03-24):

This updates the godot-cpp used by this extension to the latest on godot-cpp's 4.1 branch.

This will mean that the extension will only be compatible with Godot 4.1.4 or later due to the updates to the extension_api.json. However, if it was important than it still worked with Godot 4.1.0 to 4.1.3, then it should be possible to compile with scons custom_api_file=path/to/extension_api.json where that JSON file is from Godot 4.1.0 - and we could even stash that extension_api.json in the repo? Anyway, just let me know if you'd like adjustments for that.

However, updating to the newest godot-cpp that will work with Godot 4.1 will include a whole bunch of bug fixes that have been cherry-picked since then.

For example, PR godotengine/godot-cpp#1313 which fixes #239

As well as other various memory leaks, crashes, build-system improvements, etc.

@dsnopek
Copy link
Author

dsnopek commented Jul 10, 2024

Hm, not sure why SCons is failing on the CI, it's working for me locally...

@dsnopek dsnopek force-pushed the godot-cpp-41-branch branch from c6d6080 to a89f4cb Compare March 24, 2025 14:19
@dsnopek dsnopek changed the title Update godot-cpp to the latest on the 4.1 branch Update godot-cpp to godot-4.2-stable Mar 24, 2025
@dsnopek dsnopek marked this pull request as draft March 24, 2025 14:24
@dsnopek
Copy link
Author

dsnopek commented Mar 24, 2025

Per conversation on RocketChat, I've switched this to updating to godot-cpp's godot-4.2-stable tag (rather than the latest on the 4.1 branch)

Also, I've switched this to DRAFT because it includes the changes from PR #272 so that the CI will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes with running multiple GDExtension libraries
2 participants