Disable go license generation as part of make tidy (#33747)
#33751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems something broken `google/go-licenses` (maybe related to go 1.24), and my findings are in google/go-licenses#128 (comment). I think it's best we disable this generation for now until a better solution is found. Also, enable showing stderr output so we can actually debug this thing. For reference, these are the errors that currently apparently break the tool: ``` E0228 05:15:27.005759 13158 library.go:117] Package text/tabwriter does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128. E0228 05:15:27.005776 13158 library.go:117] Package net/http/fcgi does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128. F0228 05:15:27.028122 13158 main.go:77] some errors occurred when loading direct and transitive dependency packages ```
GiteaBot
added
modifies/internal
skip-changelog
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Feb 28, 2025
GiteaBot
added
lgtm/need 1
|
CI fails because x/crypto hasn't been bumped, but the PR to bump that dep needs this to merge |
So maybe we have to merge the two PRs as one. |
silverwind
approved these changes
Mar 1, 2025
GiteaBot
added
lgtm/done
|
Or just merge this first while ignoring CI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #33747 by @silverwind
It seems something broken
google/go-licenses(maybe related to go 1.24), and my findings are in google/go-licenses#128 (comment). I think it's best we disable this generation for now until a better solution is found.Also, enable showing stderr output so we can actually debug this thing. For reference, these are the errors that currently apparently break the tool: