Skip to content

Disable go license generation as part of make tidy (#33747) #33751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

GiteaBot
Copy link
Collaborator

Backport #33747 by @silverwind

It seems something broken google/go-licenses (maybe related to go 1.24), and my findings are in google/go-licenses#128 (comment). I think it's best we disable this generation for now until a better solution is found.

Also, enable showing stderr output so we can actually debug this thing. For reference, these are the errors that currently apparently break the tool:

E0228 05:15:27.005759   13158 library.go:117] Package text/tabwriter does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E0228 05:15:27.005776   13158 library.go:117] Package net/http/fcgi does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
F0228 05:15:27.028122   13158 main.go:77] some errors occurred when loading direct and transitive dependency packages

It seems something broken `google/go-licenses` (maybe related to go
1.24), and my findings are in
google/go-licenses#128 (comment).
I think it's best we disable this generation for now until a better
solution is found.

Also, enable showing stderr output so we can actually debug this thing.
For reference, these are the errors that currently apparently break the
tool:

```
E0228 05:15:27.005759   13158 library.go:117] Package text/tabwriter does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128.
E0228 05:15:27.005776   13158 library.go:117] Package net/http/fcgi does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128.
F0228 05:15:27.028122   13158 main.go:77] some errors occurred when loading direct and transitive dependency packages
```
@GiteaBot GiteaBot added modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 28, 2025
@GiteaBot GiteaBot requested review from delvh and lunny February 28, 2025 14:06
@GiteaBot GiteaBot added this to the 1.23.5 milestone Feb 28, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2025
@techknowlogick
Copy link
Member

CI fails because x/crypto hasn't been bumped, but the PR to bump that dep needs this to merge

@lunny
Copy link
Member

lunny commented Feb 28, 2025

CI fails because x/crypto hasn't been bumped, but the PR to bump that dep needs this to merge

So maybe we have to merge the two PRs as one.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2025
@silverwind
Copy link
Member

Or just merge this first while ignoring CI.

@lunny lunny merged commit 8939c38 into go-gitea:release/v1.23 Mar 1, 2025
25 of 26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants