Skip to content

Fix admin notice view-detail (#30450) #30458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #30450 by @silverwind

Fix #30434, regression from #30115.

I also removed the date insertion into the modal which was also broken since that date was switched to absolute-date because I see no real purpose to putting that date into the modal.

Result:

image

Fix go-gitea#30434, regression from
go-gitea#30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">
@GiteaBot GiteaBot added modifies/js modifies/templates This PR modifies the template files type/bug labels Apr 13, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2024
@GiteaBot GiteaBot requested review from lunny and wxiaoguang April 13, 2024 07:46
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 13, 2024
@silverwind silverwind merged commit fd2184e into go-gitea:release/v1.22 Apr 13, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants