Fix: Abnormal strings appear when comments are saved after editing #29991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
HEREYUA
changed the title
yardenshoham
approved these changes
Mar 22, 2024
GiteaBot
added
lgtm/need 1
I don't know whether it's realted.
|
|
I don't think so, how to reproduce? |
|
I cannot reproduce it any more. |
lunny
approved these changes
Mar 22, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
This is either |
silverwind
reviewed
Mar 22, 2024
| @@ -436,7 +436,7 @@ async function onEditContent(event) { | |||
| const $content = $segment; | |||
| if (!$content.find('.dropzone-attachments').length) { | |||
| if (data.attachments !== '') { | |||
| $content[0].append(data.attachments); | |||
| $content[0].insertAdjacentHTML('beforeend', data.attachments); | |||
There was a problem hiding this comment.
Previous code had a .dropzone-attachments class, it it no longer needed to be created, @yardenshoham?
There was a problem hiding this comment.
It's immediately replaced...
There was a problem hiding this comment.
Oh I see the previous code created and appended it, but then immediately replaced it with the HTML string, so likely it's okay.
silverwind
added
reviewed/wait-merge
silverwind
approved these changes
Mar 22, 2024
yardenshoham
added
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
yardenshoham
added
backport/v1.22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolved（The second problem）： #29986
Before
HTML strings appear when comments are saved after editing
After
2024-03-22.14.02.58.mov