De-duplicate contributor graph translations #29247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
denyskon
approved these changes
Feb 18, 2024
GiteaBot
added
lgtm/need 1
denyskon
added
the
skip-changelog
|
I want to ask maintainers, can I merge this PR into other PR's of mine in my local and keep working? Can I assume that I will be good if this PR is eventually merged into upstream? Or should I wait until it is really merged to upstream then fetch changes? |
delvh
approved these changes
Feb 18, 2024
GiteaBot
added
lgtm/done
|
No, both are fine. |
delvh
added
the
reviewed/wait-merge
delvh
changed the title
GiteaBot
removed
the
reviewed/wait-merge
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
(cherry picked from commit 20f6a7c)
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using duplicate translations and @denyskon suggested to use
%s's in translations in their review. I will make use of these translations in other PRs of mine (#29210 and #29191). If we want to include the two PRs I mentioned in v1.22, we should merge this asap.